Index: base/sys_info.h |
diff --git a/base/sys_info.h b/base/sys_info.h |
index b10747703d230fab880732bd23ba08e6661c61f8..aea7071e741de0c85a8006ab35be1c1d1af84d44 100644 |
--- a/base/sys_info.h |
+++ b/base/sys_info.h |
@@ -107,9 +107,19 @@ class BASE_EXPORT SysInfo { |
static bool GetLsbReleaseValue(const std::string& key, std::string* value); |
// Convenience function for GetLsbReleaseValue("CHROMEOS_RELEASE_BOARD",...). |
- // Returns "unknown" if CHROMEOS_RELEASE_BOARD is not set. |
+ // Returns "unknown" if CHROMEOS_RELEASE_BOARD is not set. Otherwise returns |
+ // the full name of the board. WARNING: the returned value often differs in |
+ // locally built system compared to chromebooks that use the official version. |
Thiemo Nagel
2016/11/23 20:21:19
Nit: "locally built" --> developer built
Nit: "chr
igorcov
2016/11/25 11:08:59
Done.
|
+ // E.g. for locally built version, the function could return 'glimmer' while |
+ // for officially used versions it would be like 'glimmer-signed-mp-v4keys'. |
+ // Use GetStrippedReleaseBoard() function if you need only the short name of |
+ // the board (would be 'glimmer' in the case described above). |
static std::string GetLsbReleaseBoard(); |
+ // Convenience function for GetLsbReleaseBoard() removing "-signed.." if |
Thiemo Nagel
2016/11/23 20:21:19
Nit: removing "-signed.." --> removing trailing "-
igorcov
2016/11/25 11:08:59
Done.
|
+ // present. Returns "unknown" if CHROMEOS_RELEASE_BOARD is not set. |
+ static std::string GetStrippedReleaseBoard(); |
+ |
// Returns the creation time of /etc/lsb-release. (Used to get the date and |
// time of the Chrome OS build). |
static Time GetLsbReleaseTime(); |