Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2489823002: Revert "Remove MediaStreamTrack.getSources()." (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, eric.carlson_apple.com, kinuko+watch, Srirama, miu+watch_chromium.org, extensions-reviews_chromium.org, jam, dglazkov+blink, einbinder+watch-test-runner_chromium.org, blink-reviews, darin-cc_chromium.org, xjz+watch_chromium.org, blink-reviews-api_chromium.org, mcasas+watch+mediastream_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, mcasas+watch+vc_chromium.org, chromium-apps-reviews_chromium.org, haraken, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-blink_chromium.org, avayvod+watch_chromium.org, isheriff+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Remove MediaStreamTrack.getSources()." This reverts commit 3ea42b21339ebf028e0ff6e368ca60d463386dd2. This revert is temporary in order to give time to a performance test to be fixed. TBR=rbyers@chromium.org, hbos@chromium.org BUG=662414, 649710, 388194 Committed: https://crrev.com/f29875a0a4fb3ddfa70620fbee5cb7c33f15a78d Cr-Commit-Position: refs/heads/master@{#431224}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1108 lines, -18 lines) Patch
M chrome/test/data/extensions/hangout_services_test.html View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/media_access/media_check_guest.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/webrtc/media_devices.js View 1 1 chunk +13 lines, -1 line 0 comments Download
M components/test_runner/mock_web_media_stream_center.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/mock_web_user_media_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/mock_web_user_media_client.cc View 3 chunks +39 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_center.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_center.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/user_media_client_impl.h View 4 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 5 chunks +66 lines, -0 lines 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 6 chunks +55 lines, -0 lines 0 comments Download
M content/test/data/media/getusermedia.html View 1 chunk +4 lines, -6 lines 0 comments Download
M extensions/test/data/web_view/media_access/check/media_check_guest.html View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSources.html View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSources-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 2 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesCallback.h View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesCallback.idl View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.h View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp View 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/SourceInfo.h View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/SourceInfo.cpp View 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/SourceInfo.idl View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaClient.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaController.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 3 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/exported/WebMediaStreamTrackSourcesRequest.cpp View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/exported/WebSourceInfo.cpp View 1 chunk +109 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/mediastream/MediaStreamTrackSourcesRequest.h View 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/UserMediaClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/UserMediaClientImpl.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebMediaStreamTrackSourcesRequest.h View 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebSourceInfo.h View 1 chunk +77 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebUserMediaClient.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489823002/1
4 years, 1 month ago (2016-11-09 11:24:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/331849) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years, 1 month ago (2016-11-09 12:29:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489823002/20001
4 years, 1 month ago (2016-11-09 13:57:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/328556)
4 years, 1 month ago (2016-11-09 18:40:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489823002/20001
4 years, 1 month ago (2016-11-09 20:21:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489823002/20001
4 years, 1 month ago (2016-11-09 23:17:22 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/328762)
4 years, 1 month ago (2016-11-10 01:35:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489823002/20001
4 years, 1 month ago (2016-11-10 07:45:44 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 09:34:20 UTC) #21
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f29875a0a4fb3ddfa70620fbee5cb7c33f15a78d Cr-Commit-Position: refs/heads/master@{#431224}
4 years, 1 month ago (2016-11-10 09:37:25 UTC) #23
Guido Urdaneta
4 years, 1 month ago (2016-11-10 18:05:50 UTC) #24
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2493823002/ by guidou@chromium.org.

The reason for reverting is: Relanding since the performance test affected by
this revert is being fixed..

Powered by Google App Engine
This is Rietveld 408576698