Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2489813002: Revert of Adding gantt chart to Build Status page on Buildbot Masters (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Adding gantt chart to Build Status page on Buildbot Masters (patchset #13 id:240001 of https://codereview.chromium.org/2484593002/ ) Reason for revert: This fails on all masters the moment we sync. Now, master1 was synced after a restart of chromium.fyi and this change became life on all masters of master1. Log says: File "../master.chromium/templates/build.html", line 12, in template {'name': '{{ s.getName()|escapejs }}', jinja2.exceptions.TemplateAssertionError: no filter named 'escapejs' Original issue's description: > Adding gantt chart to Build Status page on Buildbot Masters > > Screenshots: > Initial page load - https://screenshot.googleplex.com/NJjHFTcXU9T.png > After button clicked - https://screenshot.googleplex.com/QHn0DLd0Jv9.png > > BUG=663245 > TEST=local > - ran local buildbot, generated screenshots > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/f128e42562e0a67c111394c5f398ef9b1d93b6bd TBR=tansell@chromium.org,dsansome@chromium.org,estaab@chromium.org,iannucci@chromium.org,martiniss@chromium.org,sergiyb@chromium.org,philwright@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=663245, 663663 Committed: https://chromium.googlesource.com/chromium/tools/build/+/2fe427b9a0281ba645cab0a53d999545d70c887d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -532 lines) Patch
D masters/master.chromium.infra.codesearch/public_html/gantt_chart.js View 1 chunk +0 lines, -86 lines 0 comments Download
D masters/master.chromium.infra/public_html/gantt_chart.js View 1 chunk +0 lines, -86 lines 0 comments Download
M masters/master.chromium.perf.fyi/templates/build.html View 2 chunks +1 line, -17 lines 0 comments Download
D masters/master.chromium/public_html/gantt_chart.js View 1 chunk +0 lines, -86 lines 0 comments Download
M masters/master.chromium/templates/build.html View 2 chunks +1 line, -17 lines 0 comments Download
D masters/master.chromiumos/public_html/gantt_chart.js View 1 chunk +0 lines, -86 lines 0 comments Download
M masters/master.chromiumos/templates/build.html View 2 chunks +1 line, -17 lines 0 comments Download
M masters/master.tryserver.blink/templates/build.html View 2 chunks +1 line, -17 lines 0 comments Download
D masters/master.tryserver.chromium.linux/public_html/gantt_chart.js View 1 chunk +0 lines, -86 lines 0 comments Download
M masters/master.tryserver.chromium.linux/templates/build.html View 2 chunks +1 line, -17 lines 0 comments Download
M masters/master.tryserver.chromium.perf/templates/build.html View 2 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of Adding gantt chart to Build Status page on Buildbot Masters
4 years, 1 month ago (2016-11-09 10:52:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489813002/1
4 years, 1 month ago (2016-11-09 10:52:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/2fe427b9a0281ba645cab0a53d999545d70c887d
4 years, 1 month ago (2016-11-09 10:52:13 UTC) #6
Sergiy Byelozyorov
4 years, 1 month ago (2016-11-09 10:58:57 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698