[stubs] Ensure CSA_ASSERT and CSA_SLOW_ASSERT do not produce unused instructions in release mode.

src/builtins/builtins-array.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 
 #include "src/code-factory.h"
 #include "src/contexts.h"
 #include "src/elements.h"
@@ skipping 2161 matching lines @@
       iterator, JSArrayIterator::kIteratedObjectMapOffset);
   Node* array_map = assembler->LoadMap(array);
 
   Label if_isfastarray(assembler), if_isnotfastarray(assembler);
 
   assembler->Branch(assembler->WordEqual(orig_map, array_map), &if_isfastarray,
                     &if_isnotfastarray);
 
   assembler->Bind(&if_isfastarray);
   {
-    assembler->Assert(
-        assembler->Word32Equal(assembler->LoadMapInstanceType(array_map),
-                               assembler->Int32Constant(JS_ARRAY_TYPE)));
+    CSA_ASSERT(assembler,
+               assembler->Word32Equal(assembler->LoadMapInstanceType(array_map),
+                                      assembler->Int32Constant(JS_ARRAY_TYPE)));
 
     Node* length = assembler->LoadObjectField(array, JSArray::kLengthOffset);
 
-    assembler->Assert(assembler->TaggedIsSmi(length));
-    assembler->Assert(assembler->TaggedIsSmi(index));
+    CSA_ASSERT(assembler, assembler->TaggedIsSmi(length));
+    CSA_ASSERT(assembler, assembler->TaggedIsSmi(index));
 
     assembler->GotoUnless(assembler->SmiBelow(index, length), &set_done);
 
     Node* one = assembler->SmiConstant(Smi::FromInt(1));
     assembler->StoreObjectFieldNoWriteBarrier(
         iterator, JSArrayIterator::kNextIndexOffset,
         assembler->IntPtrAdd(assembler->BitcastTaggedToWord(index),
                              assembler->BitcastTaggedToWord(one)));
 
     var_done.Bind(assembler->FalseConstant());
@@ skipping 177 matching lines @@
 
         assembler->Bind(&if_isdetached);
         {
           var_length.Bind(assembler->SmiConstant(Smi::kZero));
           assembler->Goto(&done);
         }
 
         assembler->Bind(&done);
         length = var_length.value();
       }
-      assembler->Assert(assembler->TaggedIsSmi(length));
-      assembler->Assert(assembler->TaggedIsSmi(index));
+      CSA_ASSERT(assembler, assembler->TaggedIsSmi(length));
+      CSA_ASSERT(assembler, assembler->TaggedIsSmi(index));
 
       assembler->GotoUnless(assembler->SmiBelow(index, length), &set_done);
 
       Node* one = assembler->SmiConstant(Smi::FromInt(1));
       assembler->StoreObjectFieldNoWriteBarrier(
           iterator, JSArrayIterator::kNextIndexOffset,
           assembler->IntPtrAdd(assembler->BitcastTaggedToWord(index),
                                assembler->BitcastTaggedToWord(one)));
       var_done.Bind(assembler->FalseConstant());
 
@@ skipping 184 matching lines @@
         Runtime::kThrowIncompatibleMethodReceiver, context,
         assembler->HeapConstant(assembler->factory()->NewStringFromAsciiChecked(
             "Array Iterator.prototype.next", TENURED)),
         iterator);
     assembler->Return(result);
   }
 }
 
 }  // namespace internal
 }  // namespace v8