MD Settings: split appearance browser tests

MD Settings: split appearance browser tests

R=dpapad@chromium.org
BUG=none

Committed: https://crrev.com/65cb61da4988e636aed0ed677cad314298698a5a
Cr-Commit-Position: refs/heads/master@{#431170}

[Dan Beam, 2016-11-10 01:18:41]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-11-10 01:19:02]

no functional changes, just de-tangling of 2 suites in 1

[Dan Beam, 2016-11-10 01:24:08]

Patchset #1 (id:20001) has been deleted

[Dan Beam, 2016-11-10 01:24:12]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 01:24:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-11-10 02:00:46]

LGTM with nit.

https://codereview.chromium.org/2489723006/diff/30001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/cr_settings_browsertest.js (right):

https://codereview.chromium.org/2489723006/diff/30001/chrome/test/data/webui/...
chrome/test/data/webui/settings/cr_settings_browsertest.js:460: browsePreload:
'chrome://md-settings/appearance_page/appearance_page.html',
Could this load appearance_page/appearance_fonts_page.html instead, or it still
needs the entire page?

[Dan Beam, 2016-11-10 02:08:03]

https://codereview.chromium.org/2489723006/diff/30001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/cr_settings_browsertest.js (right):

https://codereview.chromium.org/2489723006/diff/30001/chrome/test/data/webui/...
chrome/test/data/webui/settings/cr_settings_browsertest.js:460: browsePreload:
'chrome://md-settings/appearance_page/appearance_page.html',
On 2016/11/10 02:00:46, dpapad wrote:
> Could this load appearance_page/appearance_fonts_page.html instead, or it
still
> needs the entire page?

Done.

[Dan Beam, 2016-11-10 02:08:10]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 02:08:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-10 02:34:54]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-11-10 02:34:58]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-11-10 02:34:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2489723006/#ps50001
(title: "fonts page")

[commit-bot: I haz the power, 2016-11-10 02:35:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 03:47:52]

Committed patchset #2 (id:50001)

[commit-bot: I haz the power, 2016-11-10 03:50:12]

Description was changed from

==========
MD Settings: split appearance browser tests

R=dpapad@chromium.org
BUG=none
==========

to

==========
MD Settings: split appearance browser tests

R=dpapad@chromium.org
BUG=none

Committed: https://crrev.com/65cb61da4988e636aed0ed677cad314298698a5a
Cr-Commit-Position: refs/heads/master@{#431170}
==========

[commit-bot: I haz the power, 2016-11-10 03:50:12]

Patchset 2 (id:??) landed as
https://crrev.com/65cb61da4988e636aed0ed677cad314298698a5a
Cr-Commit-Position: refs/heads/master@{#431170}