Run field initializers for new instance fields after a reload

Run field initializers for new instance fields after a reload

- [x] When performing a reload, track new fields with initializing expressions.
- [x] After a reload, run the initializing expressions for each new field on all instances of the class.
- [x] Unit tests (heart beat, throwing, and syntax errors)
- [x] Add some utility methods to Function, Field, and Script.
- [x] Fix a major bug in instance morphing and class hierarchy traversal.

Fixes #27666

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/a776600362b6711be3fe2afa8facba021e1b9b0b

[Cutch, 2016-11-08 23:10:13]

Description was changed from

==========
Run field initializers for new instance fields after a reload

Fixes #27666

BUG=
==========

to

==========
Run field initializers for new instance fields after a reload

Fixes #27666

BUG=
==========

[Cutch, 2016-11-08 23:10:13]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[Cutch, 2016-11-08 23:12:34]

Description was changed from

==========
Run field initializers for new instance fields after a reload

Fixes #27666

BUG=
==========

to

==========
Run field initializers for new instance fields after a reload

- [x] When performing a reload, track new fields with initializing expressions.
- [x] After a reload, run the initializing expressions for each new field on all
instances of the class.
- [x] Unit tests.
- [x] Add some utility methods to Function, Field, and Script.

Fixes #27666

BUG=
==========

[rmacnak, 2016-11-09 00:36:32]

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload.cc
File runtime/vm/isolate_reload.cc (right):

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:166: eval_func ^=  Function::EvaluateHelper(to_,
to_ -> field.owner to get the right scope

Check for compile time error.

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:175: result = DartEntry::InvokeFunction(eval_func,
Array::empty_array());
fail stop

if (result.IsError()) return result.raw();

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:1347:
instance_morphers_.At(i)->RunNewFieldInitializers();
fail stop

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload_t...
File runtime/vm/isolate_reload_test.cc (right):

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload_t...
runtime/vm/isolate_reload_test.cc:3203: // constructor is invoked.
I don't see why this should fail. Static field access doesn't depend on an
instance context.

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload_t...
runtime/vm/isolate_reload_test.cc:3241: }
Add a test where the new initializer throws.

Add a test where the new field is added to a superclass, so the correct scope of
the initializer is not the receiver class. Something like

class Super {
   static foo = "right";
   var newField = foo;
}
class Sub extends Super {
   static foo = "wrong";
}
new Sub()

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:7651: RawString* Field::InitializingExpression() const {
Copying the initializer like this means any stacktrace running this expression
will have the wrong source position. Fixing this and the analogous problem with
eval expressions probably involving adding new function kinds, so just add a
TODO for this CL.

[Cutch, 2016-11-09 23:14:08]

Description was changed from

==========
Run field initializers for new instance fields after a reload

- [x] When performing a reload, track new fields with initializing expressions.
- [x] After a reload, run the initializing expressions for each new field on all
instances of the class.
- [x] Unit tests.
- [x] Add some utility methods to Function, Field, and Script.

Fixes #27666

BUG=
==========

to

==========
Run field initializers for new instance fields after a reload

- [x] When performing a reload, track new fields with initializing expressions.
- [x] After a reload, run the initializing expressions for each new field on all
instances of the class.
- [x] Unit tests.
- [x] Add some utility methods to Function, Field, and Script.
- [x] Fix a major bug in instance morphing and class hierarchy traversal. 

Fixes #27666

BUG=
==========

[Cutch, 2016-11-09 23:19:48]

Description was changed from

==========
Run field initializers for new instance fields after a reload

- [x] When performing a reload, track new fields with initializing expressions.
- [x] After a reload, run the initializing expressions for each new field on all
instances of the class.
- [x] Unit tests.
- [x] Add some utility methods to Function, Field, and Script.
- [x] Fix a major bug in instance morphing and class hierarchy traversal. 

Fixes #27666

BUG=
==========

to

==========
Run field initializers for new instance fields after a reload

- [x] When performing a reload, track new fields with initializing expressions.
- [x] After a reload, run the initializing expressions for each new field on all
instances of the class.
- [x] Unit tests (heart beat, throwing, and syntax errors)
- [x] Add some utility methods to Function, Field, and Script.
- [x] Fix a major bug in instance morphing and class hierarchy traversal. 

Fixes #27666

BUG=
==========

[Cutch, 2016-11-09 23:20:58]

PTAL.

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload.cc
File runtime/vm/isolate_reload.cc (right):

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:166: eval_func ^=  Function::EvaluateHelper(to_,
On 2016/11/09 00:36:32, rmacnak wrote:
> to_ -> field.owner to get the right scope
> 
> Check for compile time error.

Done.

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:175: result = DartEntry::InvokeFunction(eval_func,
Array::empty_array());
On 2016/11/09 00:36:32, rmacnak wrote:
> fail stop
> 
> if (result.IsError()) return result.raw();

going with:

log error to standard error
leave field as null.

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:1347:
instance_morphers_.At(i)->RunNewFieldInitializers();
On 2016/11/09 00:36:32, rmacnak wrote:
> fail stop

Acknowledged.

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload_t...
File runtime/vm/isolate_reload_test.cc (right):

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload_t...
runtime/vm/isolate_reload_test.cc:3203: // constructor is invoked.
On 2016/11/09 00:36:32, rmacnak wrote:
> I don't see why this should fail. Static field access doesn't depend on an
> instance context.

Fails because of an ordering bug in my CL. Works now.

https://codereview.chromium.org/2489723003/diff/1/runtime/vm/isolate_reload_t...
runtime/vm/isolate_reload_test.cc:3241: }
On 2016/11/09 00:36:32, rmacnak wrote:
> Add a test where the new initializer throws.
> 

Done.

> Add a test where the new field is added to a superclass, so the correct scope
of
> the initializer is not the receiver class. Something like
> 
> class Super {
>    static foo = "right";
>    var newField = foo;
> }
> class Sub extends Super {
>    static foo = "wrong";
> }
> new Sub()

Done.

[Cutch, 2016-11-11 21:18:46]

*PING*

[rmacnak, 2016-11-11 22:22:33]

lgtm

[Cutch, 2016-11-14 21:33:26]

Description was changed from

==========
Run field initializers for new instance fields after a reload

- [x] When performing a reload, track new fields with initializing expressions.
- [x] After a reload, run the initializing expressions for each new field on all
instances of the class.
- [x] Unit tests (heart beat, throwing, and syntax errors)
- [x] Add some utility methods to Function, Field, and Script.
- [x] Fix a major bug in instance morphing and class hierarchy traversal. 

Fixes #27666

BUG=
==========

to

==========
Run field initializers for new instance fields after a reload

- [x] When performing a reload, track new fields with initializing expressions.
- [x] After a reload, run the initializing expressions for each new field on all
instances of the class.
- [x] Unit tests (heart beat, throwing, and syntax errors)
- [x] Add some utility methods to Function, Field, and Script.
- [x] Fix a major bug in instance morphing and class hierarchy traversal.

Fixes #27666

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a776600362b6711be3fe2afa8facba021e1b9b0b
==========

[Cutch, 2016-11-14 21:33:27]

Committed patchset #4 (id:60001) manually as
a776600362b6711be3fe2afa8facba021e1b9b0b (presubmit successful).