headless/lib/browser/devtools_api/client_api_generator.py - Issue 2489673005: [headless] Make browser service manifest overlay configurable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/devtools_api/client_api_generator.py

Issue 2489673005: [headless] Make browser service manifest overlay configurable. (Closed)

Patch Set: v1 load from resource id provided in options. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/browser/devtools_api/client_api_generator.py

diff --git a/headless/lib/browser/devtools_api/client_api_generator.py b/headless/lib/browser/devtools_api/client_api_generator.py

index 366b37a2c2e15294c591db841404616e6e36c82e..ce96de211b4a60c20f4b32f540fc57552188bdd2 100644

--- a/headless/lib/browser/devtools_api/client_api_generator.py

+++ b/headless/lib/browser/devtools_api/client_api_generator.py

@@ -21,8 +21,9 @@ except ImportError:

# is regenerated, which causes a race condition and breaks concurrent build,

# since some compile processes will try to read the partially written cache.

module_path, module_filename = os.path.split(os.path.realpath(__file__))

-third_party_dir = os.path.normpath(os.path.join(

- module_path, os.pardir, os.pardir, os.pardir, 'third_party'))

+third_party_dir = os.path.normpath(

+ os.path.join(module_path, os.pardir, os.pardir, os.pardir, os.pardir,

Sami 2016/11/09 18:35:52 I guess your other patch accidentally ended up her

+ 'third_party'))

templates_dir = module_path

# jinja2 is in chromium's third_party directory.