Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2489673004: gn: Include source files outside the source root for Xcode workspace (Closed)

Created:
4 years, 1 month ago by pmajewski
Modified:
4 years, 1 month ago
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org, amlynarczyk, joleksy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Include source files outside the source root for Xcode workspace This change unifies Xcode workspaces with projects for other IDEs. BUG=n/a Committed: https://crrev.com/b9f57fffd94bdfe264ddaf220dfecac603075540 Cr-Commit-Position: refs/heads/master@{#431856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M tools/gn/xcode_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/xcode_writer.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pmajewski
4 years, 1 month ago (2016-11-09 14:40:16 UTC) #3
brettw
lgtm
4 years, 1 month ago (2016-11-10 23:13:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489673004/1
4 years, 1 month ago (2016-11-14 10:03:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 11:07:23 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 11:10:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9f57fffd94bdfe264ddaf220dfecac603075540
Cr-Commit-Position: refs/heads/master@{#431856}

Powered by Google App Engine
This is Rietveld 408576698