chrome/browser/media/webrtc/webrtc_browsertest_base.h - Issue 2489673003: RTCPeerConnection.getStats: Whitelist of stats in unittest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc/webrtc_browsertest_base.h

Issue 2489673003: RTCPeerConnection.getStats: Whitelist of stats in unittest. (Closed)

Patch Set: Addressed nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/webrtc/webrtc_browsertest_base.h

diff --git a/chrome/browser/media/webrtc/webrtc_browsertest_base.h b/chrome/browser/media/webrtc/webrtc_browsertest_base.h

index 571e1a158e0ca9e20d7d8917796496d24de19517..9eb26fe966edf7fb605ba32967c3be12d0bef1a1 100644

--- a/chrome/browser/media/webrtc/webrtc_browsertest_base.h

+++ b/chrome/browser/media/webrtc/webrtc_browsertest_base.h

@@ -162,7 +162,10 @@ class WebRtcTestBase : public InProcessBrowserTest {

const std::string& keygen_algorithm) const;

void VerifyStatsGeneratedCallback(content::WebContents* tab) const;

- void VerifyStatsGeneratedPromise(content::WebContents* tab) const;

+ std::vector<std::string> VerifyStatsGeneratedPromise(

+ content::WebContents* tab) const;

+ std::vector<std::string> GetWhitelistedStatsTypes(

+ content::WebContents* tab) const;

// Change the default video codec in the offer SDP.

void SetDefaultVideoCodec(content::WebContents* tab,