Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3772)

Unified Diff: chrome/browser/media/webrtc/webrtc_browsertest.cc

Issue 2489673003: RTCPeerConnection.getStats: Whitelist of stats in unittest. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/webrtc_browsertest.cc
diff --git a/chrome/browser/media/webrtc/webrtc_browsertest.cc b/chrome/browser/media/webrtc/webrtc_browsertest.cc
index 10ead6ad37b999e8fde2b38117f2b83ff0bc9cdf..9e0a47220f0af75e4d12eb7158f5d995349dadb7 100644
--- a/chrome/browser/media/webrtc/webrtc_browsertest.cc
+++ b/chrome/browser/media/webrtc/webrtc_browsertest.cc
@@ -222,7 +222,16 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
SetupPeerconnectionWithLocalStream(right_tab_);
NegotiateCall(left_tab_, right_tab_);
- VerifyStatsGeneratedPromise(left_tab_);
+ std::set<std::string> missing_expected_stats;
+ for (const std::string str : GetWhitelistedStatsTypes(left_tab_)) {
+ missing_expected_stats.insert(str);
+ }
+ for (const std::string str : VerifyStatsGeneratedPromise(left_tab_)) {
+ missing_expected_stats.erase(str);
+ }
+ // TODO(hbos): When all stats are ready and returned by "getStats":
+ // EXPECT_TRUE(missing_expected_stats.empty());
+ // crbug.com/627816
DetectVideoAndHangUp();
}

Powered by Google App Engine
This is Rietveld 408576698