RTCPeerConnection.getStats: Whitelist of stats in unittest.

chrome/browser/media/webrtc/webrtc_browsertest_base.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/webrtc/webrtc_browsertest_base.h"
 
 #include <stddef.h>
 
+#include "base/json/json_reader.h"
 #include "base/lazy_instance.h"
 #include "base/macros.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "build/build_config.h"
 #include "chrome/browser/media/webrtc/webrtc_browsertest_common.h"
 #include "chrome/browser/permissions/permission_request_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ skipping 94 matching lines @@
     message_loop_runner_->Quit();
   }
 
   PermissionRequestManager* request_manager_;
   bool request_shown_;
   scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(PermissionRequestObserver);
 };
 
+std::vector<std::string> JsonArrayToVectorOfStrings(

[phoglund_chromium, 2016/11/10 09:01:39]

Ok, I think this ended up being a wash (I hoped you'd get less code in total),
but I think this is much safer.

[hbos_chromium, 2016/11/10 09:29:20]

:)

+    const std::string& json_array) {
+  std::unique_ptr<base::Value> value = base::JSONReader::Read(json_array);
+  EXPECT_TRUE(value);
+  EXPECT_TRUE(value->IsType(base::Value::TYPE_LIST));
+  std::unique_ptr<base::ListValue> list =
+      base::ListValue::From(std::move(value));
+  std::vector<std::string> vector;
+  vector.reserve(list->GetSize());
+  for (size_t i = 0; i < list->GetSize(); ++i) {
+    base::Value* item;
+    EXPECT_TRUE(list->Get(i, &item));
+    EXPECT_TRUE(item->IsType(base::Value::TYPE_STRING));
+    std::string item_str;
+    EXPECT_TRUE(item->GetAsString(&item_str));
+    vector.push_back(std::move(item_str));
+  }
+  return vector;
+}
+
 }  // namespace
 
 WebRtcTestBase::WebRtcTestBase(): detect_errors_in_javascript_(false) {
   // The handler gets set for each test method, but that's fine since this
   // set operation is idempotent.
   logging::SetLogMessageHandler(&JavascriptErrorDetectingLogHandler);
   hit_javascript_errors_.Get() = false;
 
   EnablePixelOutput();
 }
@@ skipping 320 matching lines @@
   std::string javascript = base::StringPrintf(
       "generateAndCloneCertificate(%s)", keygen_algorithm.c_str());
   EXPECT_EQ("ok-generated-and-cloned", ExecuteJavascript(javascript, tab));
 }
 
 void WebRtcTestBase::VerifyStatsGeneratedCallback(
     content::WebContents* tab) const {
   EXPECT_EQ("ok-got-stats", ExecuteJavascript("verifyStatsGenerated()", tab));
 }
 
-void WebRtcTestBase::VerifyStatsGeneratedPromise(
+std::vector<std::string> WebRtcTestBase::VerifyStatsGeneratedPromise(
     content::WebContents* tab) const {
-  EXPECT_EQ("ok-got-stats",
-            ExecuteJavascript("verifyStatsGeneratedPromise()", tab));
+  std::string result = ExecuteJavascript("verifyStatsGeneratedPromise()", tab);
+  EXPECT_TRUE(base::StartsWith(result, "ok-", base::CompareCase::SENSITIVE));
+  return JsonArrayToVectorOfStrings(result.substr(3));
+}
+
+std::vector<std::string> WebRtcTestBase::GetWhitelistedStatsTypes(
+    content::WebContents* tab) const {
+  return JsonArrayToVectorOfStrings(
+      ExecuteJavascript("getWhitelistedStatsTypes()", tab));
 }
 
 void WebRtcTestBase::SetDefaultVideoCodec(
     content::WebContents* tab,
     const std::string& video_codec) const {
   EXPECT_EQ("ok-forced",
             ExecuteJavascript("forceVideoCodec('" + video_codec + "')", tab));
 }
 
 void WebRtcTestBase::EnableOpusDtx(content::WebContents* tab) const {
   EXPECT_EQ("ok-forced", ExecuteJavascript("forceOpusDtx()", tab));
 }