Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2489663002: Fix CPDFSDK_FormFillEnvironment destruction order (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix CPDFSDK_FormFillEnvironment destruction order This was broken in 6c659ab2. Also fix m_PageMap naming while we're at it to match conventions. TEST=covered by forthcoming bug 662698 CL. Committed: https://pdfium.googlesource.com/pdfium/+/2599ff7ae76a2e7514c1794281ccb0802d6df2bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M fpdfsdk/cpdfsdk_formfillenvironment.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.cpp View 7 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Tom Sepez
Lei, ready for review. First part of previous CL.
4 years, 1 month ago (2016-11-08 20:20:47 UTC) #4
Lei Zhang
lgtm
4 years, 1 month ago (2016-11-08 20:40:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489663002/1
4 years, 1 month ago (2016-11-08 21:26:53 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 22:39:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/2599ff7ae76a2e7514c1794281ccb0802d6d...

Powered by Google App Engine
This is Rietveld 408576698