Fix query for GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT for GrPixelConfigs that aren't renderable

Fix query for GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT for GrPixelConfigs that aren't renderable

We recently separated renderabibilty by Skia from FBO-bindable ( https://skia-review.googlesource.com/4345). Overlooked in that change was the necessity to be able to query GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT and _TYPE for formats that we don't support rendering to Skia but are legal color attachment formats.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2489643002

Committed: https://skia.googlesource.com/skia/+/2c3db3263bdc4b91cd7d21dbfe0501fe9bd476a5

[bsalomon, 2016-11-08 18:57:34]

Description was changed from

==========
Allow query for GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT for GrPixelConfigs that
aren't Skia-renderable
==========

to

==========
Allow query for GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT for GrPixelConfigs that
aren't Skia-renderable
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2489643002
==========

[bsalomon, 2016-11-08 19:04:25]

Description was changed from

==========
Allow query for GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT for GrPixelConfigs that
aren't Skia-renderable
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2489643002
==========

to

==========
Fix query for GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT for GrPixelConfigs that
aren't renderable

We recently separated renderabibilty by Skia from FBO-bindable (
https://skia-review.googlesource.com/4345). Overlooked in that change was the
necessity to be able to query GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT and _TYPE
for formats that we don't support rendering to Skia but are legal color
attachment formats.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2489643002
==========

[bsalomon, 2016-11-08 19:04:25]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-11-08 19:51:46]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 19:51:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-11-08 20:06:14]

lgtm - so, is there a unit test we're missing?

[commit-bot: I haz the power, 2016-11-08 20:12:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 20:12:18]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[bsalomon, 2016-11-08 20:13:44]

On 2016/11/08 20:06:14, robertphillips wrote:
> lgtm - so, is there a unit test we're missing?

All this business about FBO config vs renderable config is in prep to land
support for integer textures. That change has a unit test that requires this
change to fix it. I just broke this out to not make that CL bigger.

[bsalomon, 2016-11-08 20:14:10]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-11-08 20:14:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 21:26:46]

Description was changed from

==========
Fix query for GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT for GrPixelConfigs that
aren't renderable

We recently separated renderabibilty by Skia from FBO-bindable (
https://skia-review.googlesource.com/4345). Overlooked in that change was the
necessity to be able to query GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT and _TYPE
for formats that we don't support rendering to Skia but are legal color
attachment formats.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2489643002
==========

to

==========
Fix query for GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT for GrPixelConfigs that
aren't renderable

We recently separated renderabibilty by Skia from FBO-bindable (
https://skia-review.googlesource.com/4345). Overlooked in that change was the
necessity to be able to query GR_GL_IMPLEMENTATION_COLOR_READ_FORMAT and _TYPE
for formats that we don't support rendering to Skia but are legal color
attachment formats.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2489643002

Committed:
https://skia.googlesource.com/skia/+/2c3db3263bdc4b91cd7d21dbfe0501fe9bd476a5
==========

[commit-bot: I haz the power, 2016-11-08 21:26:47]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2c3db3263bdc4b91cd7d21dbfe0501fe9bd476a5