"Go back" on the block interstitial closes the tab if there is no previous URL.

content/public/test/test_navigation_observer.cc

Index: content/public/test/test_navigation_observer.cc
diff --git a/content/public/test/test_navigation_observer.cc b/content/public/test/test_navigation_observer.cc
index e2c69b74369fabd0f3de5c48c48634464cd39067..1de33d5936ce78e1bd69dbb9c49382c0cbc8cc2d 100644
--- a/content/public/test/test_navigation_observer.cc
+++ b/content/public/test/test_navigation_observer.cc
@@ -30,6 +30,10 @@ class TestNavigationObserver::TestWebContentsObserver
     parent_->OnNavigationEntryCommitted(this, web_contents(), load_details);
   }
 
+  virtual void DidAttachInterstitialPage() OVERRIDE {
+    parent_->OnDidAttachInterstitialPage(web_contents());
+  }
+
   virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE {
     parent_->OnWebContentsDestroyed(this, web_contents);
   }
@@ -118,6 +122,13 @@ void TestNavigationObserver::OnNavigationEntryCommitted(
   navigation_started_ = true;
 }
 
+void TestNavigationObserver::OnDidAttachInterstitialPage(
+    WebContents* web_contents) {
+  // Going to an interstitial page does not trigger NavigationEntryCommited, but

[Bernhard Bauer, 2014/04/25 08:30:13]

"NavigationEntryCommitted"

[Marc Treib, 2014/04/25 08:50:34]

Done.

[Bernhard Bauer, 2014/04/29 07:57:37]

No, I meant that "committed" is spelled with double-t :) The quote were not
meant for the code.

[Marc Treib, 2014/04/29 08:14:31]

Might have made that more obvious :P
Anyway, juust in time!

+  // has the same meaning for us here.
+  navigation_started_ = true;

[Marc Treib, 2014/04/25 08:12:38]

The situation where this is required is as follows:
We open a link in a new tab, here via
ui_test_utils::NavigateToURLWithDisposition(..., NEW_FOREGROUND_TAB, ...). We
miss the DidStartLoading, since there's no way to attach the observer before
that happens. If the navigation is intercepted by an interstitial, we also don't
get a NavigationEntryCommitted, so navigation_started_ is never set to true.

+}
+
 void TestNavigationObserver::OnDidStartLoading(WebContents* web_contents) {
   navigation_started_ = true;
 }