Chromium Code Reviews

Unified Diff: Source/core/accessibility/AXObject.cpp

Issue 248963002: Making LayoutUnit conversions to Int types explicit in core/accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@patch3
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « Source/core/accessibility/AXInlineTextBox.cpp ('k') | Source/core/accessibility/AXRenderObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXObject.cpp
diff --git a/Source/core/accessibility/AXObject.cpp b/Source/core/accessibility/AXObject.cpp
index 72f4d5106bc1224e583c3b30469cb0d59332aac9..6b7039c4d8f1a9cf03d6ca4c78690cc51889a05b 100644
--- a/Source/core/accessibility/AXObject.cpp
+++ b/Source/core/accessibility/AXObject.cpp
@@ -730,7 +730,7 @@ void AXObject::scrollToMakeVisibleWithSubFocus(const IntRect& subfocus) const
if (!scrollableArea)
return;
- LayoutRect objectRect = elementRect();
+ IntRect objectRect = pixelSnappedIntRect(elementRect());
IntPoint scrollPosition = scrollableArea->scrollPosition();
IntRect scrollVisibleRect = scrollableArea->visibleContentRect();
@@ -775,8 +775,8 @@ void AXObject::scrollToGlobalPoint(const IntPoint& globalPoint) const
ScrollableArea* scrollableArea = outer->getScrollableAreaIfScrollable();
- LayoutRect innerRect = inner->isAXScrollView() ? inner->parentObject()->elementRect() : inner->elementRect();
- LayoutRect objectRect = innerRect;
+ IntRect innerRect = inner->isAXScrollView() ? pixelSnappedIntRect(inner->parentObject()->elementRect()) : pixelSnappedIntRect(inner->elementRect());
+ IntRect objectRect = innerRect;
IntPoint scrollPosition = scrollableArea->scrollPosition();
// Convert the object rect into local coordinates.
« no previous file with comments | « Source/core/accessibility/AXInlineTextBox.cpp ('k') | Source/core/accessibility/AXRenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine