Support forwarding constructors for mixin typedefs (issue 11888).

runtime/vm/class_finalizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/class_finalizer.h"
 
 #include "vm/flags.h"
 #include "vm/heap.h"
 #include "vm/isolate.h"
 #include "vm/longjump.h"
@@ skipping 1683 matching lines @@
   const String& super_name = String::Handle(super_class.Name());
   const Type& dynamic_type = Type::Handle(Type::DynamicType());
   const Array& functions = Array::Handle(super_class.functions());
   const intptr_t num_functions = functions.Length();
   Function& func = Function::Handle();
   for (intptr_t i = 0; i < num_functions; i++) {
     func ^= functions.At(i);
     if (func.IsConstructor()) {
       // Build constructor name from mixin application class name
       // and name of cloned super class constructor.
-      String& ctor_name = String::Handle(func.name());
-      ctor_name = String::SubString(ctor_name, super_name.Length());
-      String& clone_name =
-          String::Handle(String::Concat(mixin_name, ctor_name));
+      const String& ctor_name = String::Handle(func.name());
+      String& clone_name = String::Handle(
+          String::SubString(ctor_name, super_name.Length()));
+      clone_name = String::Concat(mixin_name, clone_name);
       clone_name = Symbols::New(clone_name);
 
+      if (FLAG_trace_class_finalization) {
+        OS::Print("Cloning constructor '%s' as '%s'\n",
+                  ctor_name.ToCString(),
+                  clone_name.ToCString());
+      }
       const Function& clone = Function::Handle(
           Function::New(clone_name,
                         func.kind(),
                         func.is_static(),
                         false,  // Not const.
                         false,  // Not abstract.
                         false,  // Not external.
                         mixin_app,
                         mixin_app.token_pos()));
 
@@ skipping 240 matching lines @@
     // the class conflict with inherited methods.
     ApplyMixinMembers(cls);
   }
   // Ensure super class is finalized.
   const Class& super = Class::Handle(cls.SuperClass());
   if (!super.IsNull()) {
     FinalizeClass(super);
   }
   // Mark as parsed and finalized.
   cls.Finalize();
-  // Mixin typedef classes may still lack their implicit constructor.
+  // Mixin typedef classes may still lack their forwarding constructor.
   if (cls.is_mixin_typedef() &&
       (cls.functions() == Object::empty_array().raw())) {
-    Parser::AddImplicitConstructor(cls);
+    const GrowableObjectArray& cloned_funcs =
+        GrowableObjectArray::Handle(GrowableObjectArray::New());
+    CreateForwardingConstructors(cls, cloned_funcs);
+    const Array& functions = Array::Handle(Array::MakeArray(cloned_funcs));
+    cls.SetFunctions(functions);
   }
   // Every class should have at least a constructor, unless it is a top level
   // class or a signature class.
   ASSERT(cls.IsTopLevel() ||
          cls.IsSignatureClass() ||
          (Array::Handle(cls.functions()).Length() > 0));
   // Resolve and finalize all member types.
   ResolveAndFinalizeMemberTypes(cls);
   // Run additional checks after all types are finalized.
   if (cls.is_const()) {
@@ skipping 603 matching lines @@
   expected_name ^= String::New("_offset");
   ASSERT(String::EqualsIgnoringPrivateKey(name, expected_name));
   field ^= fields_array.At(2);
   ASSERT(field.Offset() == TypedDataView::length_offset());
   name ^= field.name();
   ASSERT(name.Equals("length"));
 #endif
 }
 
 }  // namespace dart