Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2489573002: Add analysis options for front end, and fix a bug discovered by strong mode. (Closed)

Created:
4 years, 1 month ago by Paul Berry
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add analysis options for front end, and fix a bug discovered by strong mode. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/72fc9805d97cda565b7615f57acb0e99533dc0ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A + pkg/front_end/.analysis_options View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/front_end/tool/perf.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 1 month ago (2016-11-08 15:49:40 UTC) #2
Siggi Cherem (dart-lang)
lgtm, nice!
4 years, 1 month ago (2016-11-08 16:14:45 UTC) #3
Paul Berry
4 years, 1 month ago (2016-11-08 18:39:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72fc9805d97cda565b7615f57acb0e99533dc0ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698