Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2489533003: [ObjC ARC] Converts ios/net to ARC. (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/net to ARC. Notable changes: * a variadic arguments iterator is marked as unsafe_unretained. BUG=663723 TEST=None Committed: https://crrev.com/d335d77184a852bac9a0374dac0ca3deaa6ef623 Cr-Commit-Position: refs/heads/master@{#432520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -20 lines) Patch
M ios/net/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/net/clients/crn_forwarding_network_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/net/clients/crn_forwarding_network_client.mm View 2 chunks +5 lines, -1 line 0 comments Download
M ios/net/clients/crn_forwarding_network_client_factory.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/net/clients/crn_simple_network_client_factory.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M ios/net/cookies/cookie_creation_time_manager.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 2 chunks +5 lines, -1 line 0 comments Download
M ios/net/cookies/cookie_store_ios_client.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/net/cookies/system_cookie_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/net/crn_http_protocol_handler.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M ios/net/crn_http_protocol_handler_proxy_with_client_thread.mm View 3 chunks +7 lines, -3 lines 0 comments Download
M ios/net/crn_http_url_response.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/net/empty_nsurlcache.mm View 1 chunk +5 lines, -1 line 0 comments Download
M ios/net/http_protocol_logging.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/net/http_response_headers_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/net/nsurlrequest_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/net/protocol_handler_util.mm View 3 chunks +12 lines, -8 lines 0 comments Download
M ios/net/request_tracker.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/net/url_scheme_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
stkhapugin
PTAL.
4 years, 1 month ago (2016-11-09 13:40:24 UTC) #7
marq (ping after 24h)
lgtm
4 years, 1 month ago (2016-11-16 15:01:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489533003/1
4 years, 1 month ago (2016-11-16 15:37:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 16:49:15 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 17:18:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d335d77184a852bac9a0374dac0ca3deaa6ef623
Cr-Commit-Position: refs/heads/master@{#432520}

Powered by Google App Engine
This is Rietveld 408576698