Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2489523008: Fix disposing context with the new driver. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -37 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +18 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +22 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 2 chunks +10 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +28 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-10 20:44:30 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-10 20:51:54 UTC) #2
scheglov
4 years, 1 month ago (2016-11-10 21:13:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d0ee9613d46c920af838664124ea1f8a082f3909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698