Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2489523002: Fix scroll-position-restored-on-back-at-load-event.html (Closed)

Created:
4 years, 1 month ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix scroll-position-restored-on-back-at-load-event.html Follow-up of [1]. The test doesn't work if the |window.location| change occurs after document onload, and [1] makes the function in setTimeout() in DOMContentLoaded in the test to be sometimes executed (especially on debug bots) after document onload. This CL fixes the test by ensuring |window.location| change is always executed after document onload. [1] https://codereview.chromium.org/2269043002/ BUG=624697 Committed: https://crrev.com/dbfafb1dbbe4b520e2d42de5a991fe90ae4dbf7d Cr-Commit-Position: refs/heads/master@{#430591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/loader/scroll-position-restored-on-back-at-load-event.html View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hiroshige
PTAL.
4 years, 1 month ago (2016-11-08 11:41:30 UTC) #5
yhirano
lgtm
4 years, 1 month ago (2016-11-08 11:54:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489523002/1
4 years, 1 month ago (2016-11-08 11:55:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 12:34:34 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 12:36:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbfafb1dbbe4b520e2d42de5a991fe90ae4dbf7d
Cr-Commit-Position: refs/heads/master@{#430591}

Powered by Google App Engine
This is Rietveld 408576698