Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 2489513005: [Interpreter] Remove all Ldr style bytecodes and replace with Star lookahead. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc
diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc
index 60f762b98aa08a154a58dec7884e2d9e9bf2a0f3..999490518e0584520e083dbf8b6819ac1a79e347 100644
--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc
+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc
@@ -54,7 +54,7 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
.LoadLiteral(factory->NewStringFromStaticChars("A constant"))
.StoreAccumulatorInRegister(reg)
.LoadUndefined()
- .Debugger() // Prevent peephole optimization LdaNull, Star -> LdrNull.
+ .StoreAccumulatorInRegister(reg)
.LoadNull()
.StoreAccumulatorInRegister(reg)
.LoadTheHole()
@@ -308,17 +308,6 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
.StoreLookupSlot(wide_name, LanguageMode::SLOPPY)
.StoreLookupSlot(wide_name, LanguageMode::STRICT);
- // Emit loads which will be transformed to Ldr equivalents by the peephole
- // optimizer.
- builder.LoadContextSlot(reg, 1, 0)
- .StoreAccumulatorInRegister(reg)
- .LoadContextSlot(Register::current_context(), 1, 0)
- .StoreAccumulatorInRegister(reg)
- .LoadGlobal(0, TypeofMode::NOT_INSIDE_TYPEOF)
- .StoreAccumulatorInRegister(reg)
- .LoadUndefined()
- .StoreAccumulatorInRegister(reg);
-
// CreateClosureWide
builder.CreateClosure(1000, NOT_TENURED);
@@ -392,10 +381,6 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
if (!FLAG_ignition_peephole) {
// Insert entries for bytecodes only emitted by peephole optimizer.
- scorecard[Bytecodes::ToByte(Bytecode::kLdrGlobal)] = 1;
- scorecard[Bytecodes::ToByte(Bytecode::kLdrContextSlot)] = 1;
- scorecard[Bytecodes::ToByte(Bytecode::kLdrCurrentContextSlot)] = 1;
- scorecard[Bytecodes::ToByte(Bytecode::kLdrUndefined)] = 1;
scorecard[Bytecodes::ToByte(Bytecode::kLogicalNot)] = 1;
scorecard[Bytecodes::ToByte(Bytecode::kJump)] = 1;
scorecard[Bytecodes::ToByte(Bytecode::kJumpIfTrue)] = 1;

Powered by Google App Engine
This is Rietveld 408576698