Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/Modules.golden

Issue 2489513005: [Interpreter] Remove all Ldr style bytecodes and replace with Star lookahead. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/LetVariableContextSlot.golden ('k') | test/cctest/interpreter/bytecode_expectations/OuterContextVariables.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/Modules.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/Modules.golden b/test/cctest/interpreter/bytecode_expectations/Modules.golden
index 19798eb3de20d94637bf58f4f9b49fb7c019557e..0bf3703bf4ac448bafffba031e00f846ebe1d93d 100644
--- a/test/cctest/interpreter/bytecode_expectations/Modules.golden
+++ b/test/cctest/interpreter/bytecode_expectations/Modules.golden
@@ -36,13 +36,14 @@ bytecodes: [
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(3),
- B(Ldar), R(3),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(3),
B(Mov), R(closure), R(2),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(2),
- B(LdrCurrentContextSlot), U8(5), R(3),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(3),
B(LdaZero),
B(SuspendGenerator), R(3),
B(Ldar), R(2),
@@ -105,13 +106,14 @@ bytecodes: [
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(3),
- B(Ldar), R(3),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(3),
B(Mov), R(closure), R(2),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(2),
- B(LdrCurrentContextSlot), U8(5), R(3),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(3),
B(LdaZero),
B(SuspendGenerator), R(3),
B(Ldar), R(2),
@@ -153,7 +155,7 @@ snippet: "
"
frame size: 9
parameter count: 2
-bytecode array length: 193
+bytecode array length: 195
bytecodes: [
B(Ldar), R(new_target),
B(JumpIfUndefined), U8(21),
@@ -176,13 +178,14 @@ bytecodes: [
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(4),
- B(Ldar), R(4),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(4),
B(Mov), R(closure), R(3),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(3), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(3), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(3),
- B(LdrCurrentContextSlot), U8(5), R(4),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(4),
B(LdaZero),
B(SuspendGenerator), R(4),
B(Ldar), R(3),
@@ -207,7 +210,8 @@ bytecodes: [
/* 64 S> */ B(Return),
B(Ldar), R(5),
/* 0 E> */ B(Throw),
- /* 32 S> */ B(LdrUndefined), R(4),
+ /* 32 S> */ B(LdaUndefined),
+ B(Star), R(4),
/* 32 E> */ B(LdaModuleVariable), U8(-1), U8(0),
B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(1),
@@ -224,7 +228,8 @@ bytecodes: [
B(StaCurrentContextSlot), U8(4),
/* 47 S> */ B(LdaUndefined),
/* 47 E> */ B(StaCurrentContextSlot), U8(4),
- /* 52 S> */ B(LdrUndefined), R(4),
+ /* 52 S> */ B(LdaUndefined),
+ B(Star), R(4),
/* 52 E> */ B(LdaModuleVariable), U8(-1), U8(1),
B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(1),
@@ -277,13 +282,14 @@ bytecodes: [
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(4),
- B(Ldar), R(4),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(4),
B(Mov), R(closure), R(3),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(3), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(3), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(3),
- B(LdrCurrentContextSlot), U8(5), R(4),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(4),
B(LdaZero),
B(SuspendGenerator), R(4),
B(Ldar), R(3),
@@ -367,13 +373,14 @@ bytecodes: [
B(LdaTheHole),
B(StaModuleVariable), U8(1), U8(0),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(4),
- B(Ldar), R(4),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(4),
B(Mov), R(closure), R(3),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(3), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(3), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(3),
- B(LdrCurrentContextSlot), U8(5), R(4),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(4),
B(LdaZero),
B(SuspendGenerator), R(4),
B(Ldar), R(3),
@@ -457,13 +464,14 @@ bytecodes: [
B(LdaTheHole),
B(StaModuleVariable), U8(1), U8(0),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(4),
- B(Ldar), R(4),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(4),
B(Mov), R(closure), R(3),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(3), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(3), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(3),
- B(LdrCurrentContextSlot), U8(5), R(4),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(4),
B(LdaZero),
B(SuspendGenerator), R(4),
B(Ldar), R(3),
@@ -545,13 +553,14 @@ bytecodes: [
B(LdaTheHole),
B(StaModuleVariable), U8(1), U8(0),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(3),
- B(Ldar), R(3),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(3),
B(Mov), R(closure), R(2),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(2),
- B(LdrCurrentContextSlot), U8(5), R(3),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(3),
B(LdaZero),
B(SuspendGenerator), R(3),
B(Ldar), R(2),
@@ -619,13 +628,14 @@ bytecodes: [
B(LdaTheHole),
B(StaModuleVariable), U8(1), U8(0),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(3),
- B(Ldar), R(3),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(3),
B(Mov), R(closure), R(2),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(2),
- B(LdrCurrentContextSlot), U8(5), R(3),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(3),
B(LdaZero),
B(SuspendGenerator), R(3),
B(Ldar), R(2),
@@ -664,8 +674,8 @@ bytecodes: [
B(Star), R(3),
B(CallRuntime), U16(Runtime::kToFastProperties), R(2), U8(1),
B(StaCurrentContextSlot), U8(6),
- /* 16 E> */ B(LdaCurrentContextSlot), U8(6),
- B(StaModuleVariable), U8(1), U8(0),
+ B(LdaCurrentContextSlot), U8(6),
+ /* 16 E> */ B(StaModuleVariable), U8(1), U8(0),
B(LdaUndefined),
/* 26 S> */ B(Return),
]
@@ -706,13 +716,14 @@ bytecodes: [
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(3),
- B(Ldar), R(3),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(3),
B(Mov), R(closure), R(2),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(2),
- B(LdrCurrentContextSlot), U8(5), R(3),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(3),
B(LdaZero),
B(SuspendGenerator), R(3),
B(Ldar), R(2),
@@ -775,13 +786,14 @@ bytecodes: [
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(3),
- B(Ldar), R(3),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(3),
B(Mov), R(closure), R(2),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(2),
- B(LdrCurrentContextSlot), U8(5), R(3),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(3),
B(LdaZero),
B(SuspendGenerator), R(3),
B(Ldar), R(2),
@@ -822,7 +834,7 @@ snippet: "
"
frame size: 8
parameter count: 2
-bytecode array length: 161
+bytecode array length: 164
bytecodes: [
B(Ldar), R(new_target),
B(JumpIfUndefined), U8(21),
@@ -849,13 +861,14 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kGetModuleNamespace), R(2), U8(1),
B(StaCurrentContextSlot), U8(6),
/* 0 E> */ B(StackCheck),
- /* 0 E> */ B(LdrCurrentContextSlot), U8(4), R(3),
- B(Ldar), R(3),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(3),
B(Mov), R(closure), R(2),
- B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
+ /* 0 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(2), U8(2),
B(StaCurrentContextSlot), U8(5),
B(Star), R(2),
- B(LdrCurrentContextSlot), U8(5), R(3),
+ B(LdaCurrentContextSlot), U8(5),
+ B(Star), R(3),
B(LdaZero),
B(SuspendGenerator), R(3),
B(Ldar), R(2),
@@ -880,11 +893,14 @@ bytecodes: [
/* 45 S> */ B(Return),
B(Ldar), R(4),
/* 0 E> */ B(Throw),
- /* 27 S> */ B(LdrCurrentContextSlot), U8(6), R(3),
+ /* 27 S> */ B(LdaCurrentContextSlot), U8(6),
+ B(Star), R(3),
/* 30 E> */ B(LdaNamedProperty), R(3), U8(1), U8(4),
B(Star), R(2),
- /* 33 E> */ B(LdrCurrentContextSlot), U8(6), R(4),
- /* 38 E> */ B(LdrCurrentContextSlot), U8(6), R(6),
+ B(LdaCurrentContextSlot), U8(6),
+ B(Star), R(4),
+ B(LdaCurrentContextSlot), U8(6),
+ B(Star), R(6),
/* 41 E> */ B(LdaNamedProperty), R(6), U8(2), U8(6),
B(Star), R(5),
/* 31 E> */ B(CallProperty), R(2), R(3), U8(3), U8(2),
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/LetVariableContextSlot.golden ('k') | test/cctest/interpreter/bytecode_expectations/OuterContextVariables.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698