Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: src/interpreter/mkpeephole.cc

Issue 2489513005: [Interpreter] Remove all Ldr style bytecodes and replace with Star lookahead. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/interpreter.cc ('k') | test/cctest/interpreter/bytecode_expectations/CallGlobal.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/mkpeephole.cc
diff --git a/src/interpreter/mkpeephole.cc b/src/interpreter/mkpeephole.cc
index 3fc32bc792bca9e10a10cd9923898ba120fc1673..62d3a77e02c7faf513f1d8ff020217b6fd4785dd 100644
--- a/src/interpreter/mkpeephole.cc
+++ b/src/interpreter/mkpeephole.cc
@@ -79,30 +79,6 @@ const char* PeepholeActionTableWriter::kNamespaceElements[] = {"v8", "internal",
// static
PeepholeActionAndData PeepholeActionTableWriter::LookupActionAndData(
Bytecode last, Bytecode current) {
- // Optimize various accumulator loads followed by store accumulator
- // to an equivalent register load and loading the accumulator with
- // the register. The latter accumulator load can often be elided as
- // it is side-effect free and often followed by another accumulator
- // load so can be elided.
- if (current == Bytecode::kStar) {
- switch (last) {
- case Bytecode::kLdaGlobal:
- return {PeepholeAction::kTransformLdaStarToLdrLdarAction,
- Bytecode::kLdrGlobal};
- case Bytecode::kLdaContextSlot:
- return {PeepholeAction::kTransformLdaStarToLdrLdarAction,
- Bytecode::kLdrContextSlot};
- case Bytecode::kLdaCurrentContextSlot:
- return {PeepholeAction::kTransformLdaStarToLdrLdarAction,
- Bytecode::kLdrCurrentContextSlot};
- case Bytecode::kLdaUndefined:
- return {PeepholeAction::kTransformLdaStarToLdrLdarAction,
- Bytecode::kLdrUndefined};
- default:
- break;
- }
- }
-
// ToName bytecodes can be replaced by Star with the same output register if
// the value in the accumulator is already a name.
if (current == Bytecode::kToName && Bytecodes::PutsNameInAccumulator(last)) {
« no previous file with comments | « src/interpreter/interpreter.cc ('k') | test/cctest/interpreter/bytecode_expectations/CallGlobal.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698