[Interpreter] Remove all Ldr style bytecodes and replace with Star lookahead.

test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/factory.h"
 #include "src/interpreter/bytecode-label.h"
 #include "src/interpreter/bytecode-peephole-optimizer.h"
 #include "src/objects-inl.h"
@@ skipping 303 matching lines @@
   optimizer()->Write(&second);
   CHECK_EQ(write_count(), 0);
   Flush();
   CHECK_EQ(write_count(), 1);
   BytecodeNode expected(Bytecode::kStackCheck, source_info);
   CHECK_EQ(last_written(), expected);
 }
 
 // Tests covering BytecodePeepholeOptimizer::UpdateLastAndCurrentBytecodes().
 
-TEST_F(BytecodePeepholeOptimizerTest, MergeLdaGlobalStar) {
-  const uint32_t operands[] = {19191,
-                               static_cast<uint32_t>(Register(1).ToOperand())};
-  const int expected_operand_count = static_cast<int>(arraysize(operands));
-
-  BytecodeNode first(Bytecode::kLdaGlobal, operands[0]);
-  BytecodeNode second(Bytecode::kStar, operands[1]);
-  BytecodeNode third(Bytecode::kReturn);
-  optimizer()->Write(&first);
-  optimizer()->Write(&second);
-  CHECK_EQ(write_count(), 1);
-  CHECK_EQ(last_written().bytecode(), Bytecode::kLdrGlobal);
-  CHECK_EQ(last_written().operand_count(), expected_operand_count);
-  for (int i = 0; i < expected_operand_count; ++i) {
-    CHECK_EQ(last_written().operand(i), operands[i]);
-  }
-  optimizer()->Write(&third);
-  CHECK_EQ(write_count(), 2);
-  CHECK_EQ(last_written().bytecode(), Bytecode::kLdar);
-  CHECK_EQ(last_written().operand(0), operands[expected_operand_count - 1]);
-  Flush();
-  CHECK_EQ(last_written().bytecode(), third.bytecode());
-}
-
-TEST_F(BytecodePeepholeOptimizerTest, MergeLdaContextSlotStar) {
-  const uint32_t operands[] = {
-      static_cast<uint32_t>(Register(200000).ToOperand()), 55005500,
-      static_cast<uint32_t>(Register(0).ToOperand()),
-      static_cast<uint32_t>(Register(1).ToOperand())};
-  const int expected_operand_count = static_cast<int>(arraysize(operands));
-
-  BytecodeNode first(Bytecode::kLdaContextSlot, operands[0], operands[1],
-                     operands[2]);
-  BytecodeNode second(Bytecode::kStar, operands[3]);
-  BytecodeNode third(Bytecode::kReturn);
-  optimizer()->Write(&first);
-  optimizer()->Write(&second);
-  CHECK_EQ(write_count(), 1);
-  CHECK_EQ(last_written().bytecode(), Bytecode::kLdrContextSlot);
-  CHECK_EQ(last_written().operand_count(), expected_operand_count);
-  for (int i = 0; i < expected_operand_count; ++i) {
-    CHECK_EQ(last_written().operand(i), operands[i]);
-  }
-  optimizer()->Write(&third);
-  CHECK_EQ(write_count(), 2);
-  CHECK_EQ(last_written().bytecode(), Bytecode::kLdar);
-  CHECK_EQ(last_written().operand(0), operands[expected_operand_count - 1]);
-  Flush();
-  CHECK_EQ(last_written().bytecode(), third.bytecode());
-}
-
-TEST_F(BytecodePeepholeOptimizerTest, MergeLdaUndefinedStar) {
-  const uint32_t operands[] = {
-      static_cast<uint32_t>(Register(100000).ToOperand())};
-  const int expected_operand_count = static_cast<int>(arraysize(operands));
-
-  BytecodeNode first(Bytecode::kLdaUndefined);
-  BytecodeNode second(Bytecode::kStar, operands[0]);
-  BytecodeNode third(Bytecode::kReturn);
-  optimizer()->Write(&first);
-  optimizer()->Write(&second);
-  CHECK_EQ(write_count(), 1);
-  CHECK_EQ(last_written().bytecode(), Bytecode::kLdrUndefined);
-  CHECK_EQ(last_written().operand_count(), expected_operand_count);
-  for (int i = 0; i < expected_operand_count; ++i) {
-    CHECK_EQ(last_written().operand(i), operands[i]);
-  }
-  optimizer()->Write(&third);
-  CHECK_EQ(write_count(), 2);
-  CHECK_EQ(last_written().bytecode(), Bytecode::kLdar);
-  CHECK_EQ(last_written().operand(0), operands[expected_operand_count - 1]);
-  Flush();
-  CHECK_EQ(last_written().bytecode(), third.bytecode());
-}
-
 TEST_F(BytecodePeepholeOptimizerTest, MergeLdaSmiWithBinaryOp) {
   Bytecode operator_replacement_pairs[][2] = {
       {Bytecode::kAdd, Bytecode::kAddSmi},
       {Bytecode::kSub, Bytecode::kSubSmi},
       {Bytecode::kBitwiseAnd, Bytecode::kBitwiseAndSmi},
       {Bytecode::kBitwiseOr, Bytecode::kBitwiseOrSmi},
       {Bytecode::kShiftLeft, Bytecode::kShiftLeftSmi},
       {Bytecode::kShiftRight, Bytecode::kShiftRightSmi}};
 
   for (auto operator_replacement : operator_replacement_pairs) {
@@ skipping 65 matching lines @@
     CHECK_EQ(last_written().operand(0), 0);
     CHECK_EQ(last_written().operand(1), reg_operand);
     CHECK_EQ(last_written().operand(2), idx_operand);
     Reset();
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8