Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 2489513003: Fixes and test updates for aura-mus (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/widget_unittest.cc
diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc
index bad9edd96f4c760a9a701112e1448bf2031b5596..6a66139c7d8cb47911d69eb5c7ab22410f88856f 100644
--- a/ui/views/widget/widget_unittest.cc
+++ b/ui/views/widget/widget_unittest.cc
@@ -847,6 +847,10 @@ TEST_F(WidgetObserverTest, DISABLED_VisibilityChange) {
}
TEST_F(WidgetObserverTest, DestroyBubble) {
+ // This test expect NativeWidgetAura, force it's creation.
msw 2016/11/08 23:38:27 nit: "its"
sky 2016/11/09 00:06:01 Done.
+ ViewsDelegate::GetInstance()->set_native_widget_factory(
+ ViewsDelegate::NativeWidgetFactory());
+
WidgetAutoclosePtr anchor(CreateTopLevelPlatformWidget());
anchor->Show();
@@ -1271,6 +1275,11 @@ TEST_F(WidgetTest, DISABLED_FocusChangesOnBubble) {
}
TEST_F(WidgetTest, BubbleControlsResetOnInit) {
+ // This test creates a NativeWidgetAura and then a bubble parented to it. This
+ // means the test needs a NativeWidgetAura for the bubble as well.
+ ViewsDelegate::GetInstance()->set_native_widget_factory(
+ ViewsDelegate::NativeWidgetFactory());
+
WidgetAutoclosePtr anchor(CreateTopLevelPlatformWidget());
anchor->Show();

Powered by Google App Engine
This is Rietveld 408576698