Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: components/offline_pages/core/background/BUILD.gn

Issue 2489443002: Move all components/offline_pages/ files into component/offline_pages/core (Closed)
Patch Set: more rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/BUILD.gn
diff --git a/components/offline_pages/background/BUILD.gn b/components/offline_pages/core/background/BUILD.gn
similarity index 93%
rename from components/offline_pages/background/BUILD.gn
rename to components/offline_pages/core/background/BUILD.gn
index 67442cefdfe4a0012d331791984938351431783d..9b33e88ab0b502dd6b2ba4de350f7b7e46c50a78 100644
--- a/components/offline_pages/background/BUILD.gn
+++ b/components/offline_pages/core/background/BUILD.gn
@@ -49,9 +49,8 @@ static_library("background_offliner") {
deps = [
"//base",
"//components/keyed_service/core",
- "//components/offline_pages:offline_pages",
- "//components/offline_pages:switches",
"//components/offline_pages/core",
+ "//components/offline_pages/core:switches",
Pete Williamson 2016/12/06 02:02:24 Does the background component still need switches?
chili 2016/12/06 19:08:53 Not sure, but I'd rather keep everything the same
dougarnett 2016/12/06 20:10:13 Believe this is needed for offline_pages::IsOfflin
"//net",
"//sql:sql",
"//url",
@@ -99,8 +98,8 @@ source_set("unit_tests") {
":test_support",
"//base",
"//base/test:test_support",
- "//components/offline_pages:offline_pages",
- "//components/offline_pages:switches",
+ "//components/offline_pages/core",
+ "//components/offline_pages/core:switches",
"//testing/gtest",
"//url",
]

Powered by Google App Engine
This is Rietveld 408576698