Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2489433003: [ic] Enable data handlers for all kinds of field stores. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Enable data handlers for all kinds of field stores. BUG=v8:5561 Committed: https://crrev.com/f124edd97dc7774c46bac352991a3514d3dd6cc1 Cr-Commit-Position: refs/heads/master@{#40929}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -47 lines) Patch
M src/flag-definitions.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 1 3 chunks +15 lines, -45 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-08 08:57:33 UTC) #2
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-08 13:13:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489433003/20001
4 years, 1 month ago (2016-11-11 14:05:30 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 14:15:19 UTC) #11
Michael Achenbach
On 2016/11/11 14:15:19, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) Predictable ...
4 years, 1 month ago (2016-11-11 21:00:08 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:53 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f124edd97dc7774c46bac352991a3514d3dd6cc1
Cr-Commit-Position: refs/heads/master@{#40929}

Powered by Google App Engine
This is Rietveld 408576698