Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: components/password_manager/sync/browser/password_model_worker.cc

Issue 2489433002: [Sync] Move thread checking into the ModelSafeWorker interface. (Closed)
Patch Set: Improve/add comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/sync/browser/password_model_worker.cc
diff --git a/components/password_manager/sync/browser/password_model_worker.cc b/components/password_manager/sync/browser/password_model_worker.cc
index 91d17c883f50439c547f33cd8ad18acbe796b24f..81fb889b3b53dfbbfb756cde2a379247fd2e608d 100644
--- a/components/password_manager/sync/browser/password_model_worker.cc
+++ b/components/password_manager/sync/browser/password_model_worker.cc
@@ -62,6 +62,13 @@ syncer::ModelSafeGroup PasswordModelWorker::GetModelSafeGroup() {
return syncer::GROUP_PASSWORD;
}
+bool PasswordModelWorker::IsOnModelThread() {
+ // Ideally PasswordStore would expose a way to check whether this is the
+ // thread it does work on. Since it doesn't, just return true to bypass a
+ // CHECK in the sync code.
+ return true;
+}
+
PasswordModelWorker::~PasswordModelWorker() {}
void PasswordModelWorker::RequestStop() {

Powered by Google App Engine
This is Rietveld 408576698