Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: components/sync/driver/glue/browser_thread_model_worker.h

Issue 2489433002: [Sync] Move thread checking into the ModelSafeWorker interface. (Closed)
Patch Set: Improve/add comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_ 5 #ifndef COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_
6 #define COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_ 6 #define COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
11 #include "components/sync/base/scoped_event_signal.h" 11 #include "components/sync/base/scoped_event_signal.h"
12 #include "components/sync/base/syncer_error.h" 12 #include "components/sync/base/syncer_error.h"
13 #include "components/sync/engine/model_safe_worker.h" 13 #include "components/sync/engine/model_safe_worker.h"
14 14
15 namespace syncer { 15 namespace syncer {
16 16
17 // A ModelSafeWorker for models that accept requests from the 17 // A ModelSafeWorker for models that accept requests from the
18 // syncapi that need to be fulfilled on a browser thread, for example 18 // syncapi that need to be fulfilled on a browser thread, for example
19 // autofill on the DB thread. 19 // autofill on the DB thread.
20 // TODO(sync): Try to generalize other ModelWorkers (e.g. history, etc). 20 // TODO(sync): Try to generalize other ModelWorkers (e.g. history, etc).
21 class BrowserThreadModelWorker : public ModelSafeWorker { 21 class BrowserThreadModelWorker : public ModelSafeWorker {
22 public: 22 public:
23 BrowserThreadModelWorker( 23 BrowserThreadModelWorker(
24 const scoped_refptr<base::SingleThreadTaskRunner>& runner, 24 const scoped_refptr<base::SingleThreadTaskRunner>& runner,
25 ModelSafeGroup group); 25 ModelSafeGroup group);
26 26
27 // ModelSafeWorker implementation. Called on the sync thread. 27 // ModelSafeWorker implementation.
28 ModelSafeGroup GetModelSafeGroup() override; 28 ModelSafeGroup GetModelSafeGroup() override;
29 bool IsOnModelThread() override;
29 30
30 protected: 31 protected:
31 ~BrowserThreadModelWorker() override; 32 ~BrowserThreadModelWorker() override;
32 33
33 SyncerError DoWorkAndWaitUntilDoneImpl(const WorkCallback& work) override; 34 SyncerError DoWorkAndWaitUntilDoneImpl(const WorkCallback& work) override;
34 35
35 void CallDoWorkAndSignalTask(const WorkCallback& work, 36 void CallDoWorkAndSignalTask(const WorkCallback& work,
36 syncer::ScopedEventSignal scoped_event_signal, 37 syncer::ScopedEventSignal scoped_event_signal,
37 SyncerError* error); 38 SyncerError* error);
38 39
39 private: 40 private:
40 scoped_refptr<base::SingleThreadTaskRunner> runner_; 41 scoped_refptr<base::SingleThreadTaskRunner> runner_;
41 ModelSafeGroup group_; 42 ModelSafeGroup group_;
42 43
43 DISALLOW_COPY_AND_ASSIGN(BrowserThreadModelWorker); 44 DISALLOW_COPY_AND_ASSIGN(BrowserThreadModelWorker);
44 }; 45 };
45 46
46 } // namespace syncer 47 } // namespace syncer
47 48
48 #endif // COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_ 49 #endif // COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698