[Sync] Move thread checking into the ModelSafeWorker interface.

components/password_manager/sync/browser/password_model_worker.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/sync/browser/password_model_worker.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/synchronization/waitable_event.h"
 #include "components/password_manager/core/browser/password_store.h"
@@ skipping 44 matching lines @@
     work_done_or_abandoned.Wait();
   else
     error = syncer::CANNOT_DO_WORK;
   return error;
 }
 
 syncer::ModelSafeGroup PasswordModelWorker::GetModelSafeGroup() {
   return syncer::GROUP_PASSWORD;
 }
 
+bool PasswordModelWorker::IsOnModelThread() {
+  // Can't do better without modifying PasswordStore.

[vabr (Chromium), 2016/11/08 08:32:45]

Please explain the issue better. Ideally, the issue would be described in a bug
in more detail (what needs to be done in PasswordStore, how it relates to the
worker, etc.), and the comment here could just say: TODO(crbug.com/XXX) Can't do
better without modifying PasswordStore.

[maxbogue, 2016/11/08 18:43:23]

I've improved the comment to hopefully be clearer about what's going on. I'm not
filing a bug because nobody actually intends to fix this; it's sat untouched in
sync code for years and we're beginning to move types to the new USS style,
which doesn't use this interface.

[vabr (Chromium), 2016/11/08 19:24:59]

Acknowledged. If there was a need to implement this in PasswordStore, do let me
know, it should not be a problem to add this. Other than that, the new comment
looks clear enough to me and does not require a bug.

+  return true;
+}
+
 PasswordModelWorker::~PasswordModelWorker() {}
 
 void PasswordModelWorker::RequestStop() {
   ModelSafeWorker::RequestStop();
 
   base::AutoLock lock(password_store_lock_);
   password_store_ = NULL;
 }
 
 }  // namespace browser_sync