DevTools: Ghost text shouldn't affect textWithCurrentSuggestion

third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

 /*
  * Copyright (C) 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 133 matching lines @@
     this._proxyElement.remove();
     delete this._proxyElement;
     this._element.classList.remove('text-prompt');
     this._focusRestorer.restore();
   }
 
   /**
    * @return {string}
    */
   textWithCurrentSuggestion() {
-    return this._element.textContent;
+    var text = this.text();
+    if (!this._queryRange)
+      return text;
+    return text.substring(0, this._queryRange.startColumn) + this._currentSuggestion +
+        text.substring(this._queryRange.endColumn);
   }
 
   /**
    * @return {string}
    */
   text() {
-    var text = this.textWithCurrentSuggestion();
+    var text = this._element.textContent;
     if (this._ghostTextElement.parentNode) {
       var addition = this._ghostTextElement.textContent;
       text = text.substring(0, text.length - addition.length);
     }
     return text;
   }
 
   /**
    * @param {string} x
    */
@@ skipping 340 matching lines @@
   /**
    * @override
    */
   acceptSuggestion() {
     this._acceptSuggestionInternal();
   }
 
   /**
    * @return {boolean}
    */
   _acceptSuggestionInternal() {

[einbinder, 2016/11/10 20:05:32]

This becomes wonderfully readable.

     if (!this._queryRange)
       return false;
 
-    var text = this.text();
-    this._element.textContent = text.substring(0, this._queryRange.startColumn) + this._currentSuggestion +
-        text.substring(this._queryRange.endColumn);
+    this._element.textContent = this.textWithCurrentSuggestion();
     this.setDOMSelection(
         this._queryRange.startColumn + this._currentSuggestion.length,
         this._queryRange.startColumn + this._currentSuggestion.length);
 
     this.clearAutocomplete();
     this.dispatchEventToListeners(WebInspector.TextPrompt.Events.ItemAccepted);
 
     return true;
   }
 
@@ skipping 97 matching lines @@
   }
 };
 
 WebInspector.TextPrompt.DefaultAutocompletionTimeout = 250;
 
 /** @enum {symbol} */
 WebInspector.TextPrompt.Events = {
   ItemApplied: Symbol('text-prompt-item-applied'),
   ItemAccepted: Symbol('text-prompt-item-accepted')
 };