DevTools: Ghost text shouldn't affect textWithCurrentSuggestion

DevTools: Ghost text shouldn't affect textWithCurrentSuggestion

Before, textWithCurrentSuggestion was really textWithGhostText.
You can have autocomplete without ghost text now, so it wasn't always
accurate.
With this patch, scrolling through the styles sidebar always applies
the current suggestion even if there is no ghost text.

BUG=660941
Committed: https://crrev.com/b80ee94906688a5b57690631ecc89e398e5e1fbe
Cr-Commit-Position: refs/heads/master@{#431528}

[einbinder, 2016-11-10 20:05:31]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-11-10 20:05:32]

ptal

https://codereview.chromium.org/2489403002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js (right):

https://codereview.chromium.org/2489403002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:526:
_acceptSuggestionInternal() {
This becomes wonderfully readable.

[einbinder, 2016-11-10 20:05:44]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 20:06:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-11-10 21:56:07]

lgtm

[commit-bot: I haz the power, 2016-11-10 22:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 22:44:17]

Dry run: This issue passed the CQ dry run.

[einbinder, 2016-11-11 08:48:44]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2016-11-11 08:48:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 08:53:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-11 08:55:23]

Description was changed from

==========
DevTools: Ghost text shouldn't affect textWithCurrentSuggestion

Before, textWithCurrentSuggestion was really textWithGhostText.
You can have autocomplete without ghost text now, so it wasn't always
accurate.
With this patch, scrolling through the styles sidebar always applies
the current suggestion even if there is no ghost text.

BUG=660941
==========

to

==========
DevTools: Ghost text shouldn't affect textWithCurrentSuggestion

Before, textWithCurrentSuggestion was really textWithGhostText.
You can have autocomplete without ghost text now, so it wasn't always
accurate.
With this patch, scrolling through the styles sidebar always applies
the current suggestion even if there is no ghost text.

BUG=660941

Committed: https://crrev.com/b80ee94906688a5b57690631ecc89e398e5e1fbe
Cr-Commit-Position: refs/heads/master@{#431528}
==========

[commit-bot: I haz the power, 2016-11-11 08:55:24]

Patchset 1 (id:??) landed as
https://crrev.com/b80ee94906688a5b57690631ecc89e398e5e1fbe
Cr-Commit-Position: refs/heads/master@{#431528}