Issue 2489383002: Don't add imports/exports elements for invalid URIs, with null Source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2489383002: Don't add imports/exports elements for invalid URIs, with null Source. (Closed)

Created:
4 years, 1 month ago by scheglov

Modified:
4 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't add imports/exports elements for invalid URIs, with null Source. Unfortunately I have to roll back the optimization. We need to know whether the URI is valid earlier. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5694cca15ef15c716ce286a4a6e5e7ac5ead41a3

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -13 lines)			Patch
M	pkg/analyzer/lib/src/dart/element/element.dart	View	2 chunks	+21 lines, -8 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/analysis/driver_test.dart	View	1 chunk	+34 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 1 month ago (2016-11-10 19:49:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5694cca15ef15c716ce286a4a6e5e7ac5ead41a3 (presubmit successful).