Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2489373002: [Mac] (More) RTL support for tab strip (Closed)

Created:
4 years, 1 month ago by lgrey
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] (More) RTL support for tab strip Still needs work re: dragging and profile switcher, but this change fixes most of the remaining layout issues and rapid close mode. BUG=648559 Committed: https://crrev.com/144e6019d55ce9a31b22b68b045f05eddd8bfae0 Cr-Commit-Position: refs/heads/master@{#431582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -65 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout_unittest.mm View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 13 chunks +73 lines, -32 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
lgrey
PTAL :) Elly for RTL, Mark for OWNERS
4 years, 1 month ago (2016-11-10 17:36:59 UTC) #2
Elly Fong-Jones
lgtm
4 years, 1 month ago (2016-11-11 13:53:57 UTC) #3
Mark Mentovai
LGTM
4 years, 1 month ago (2016-11-11 14:54:08 UTC) #4
lgrey
Thanks!
4 years, 1 month ago (2016-11-11 15:01:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489373002/1
4 years, 1 month ago (2016-11-11 15:01:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/333645)
4 years, 1 month ago (2016-11-11 16:15:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489373002/1
4 years, 1 month ago (2016-11-11 16:40:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 16:57:05 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 16:59:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/144e6019d55ce9a31b22b68b045f05eddd8bfae0
Cr-Commit-Position: refs/heads/master@{#431582}

Powered by Google App Engine
This is Rietveld 408576698