Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2489363002: Rename setters synthetic/static to isSynthetic/isStatic. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename setters synthetic/static to isSynthetic/isStatic. Also rename ConstructorElementImpl.const2 to isConst. These are breaking changes. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1ac36f7c3872911b897fc1c61ac90bd9489d650d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -112 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 14 chunks +15 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 28 chunks +59 lines, -59 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 8 chunks +13 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/analysis_context_factory.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/inheritance_manager_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-10 17:10:25 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-10 17:23:40 UTC) #2
scheglov
4 years, 1 month ago (2016-11-10 20:23:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ac36f7c3872911b897fc1c61ac90bd9489d650d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698