WebView Proguard: Keep AwBrowserProcess.sExclusiveFileLock.

WebView Proguard: Keep AwBrowserProcess.sExclusiveFileLock.

Static fields in Java are often assumed to stay alive throughout the
runtime of the entire program. However, the proguard
field/removal/writeonly optimization removes even static fields that are
only written to. This breaks some WebView code that relies on static
fields to hold onto a file-lock which prevents file-access from other
processes.

In this CL we explicitly tell proguard to keep
AwBrowserProcess.sExclusiveFileLock.

BUG=647291
Committed: https://crrev.com/d7730964c696db73bde4cc1ea6d07d3f09f85765
Cr-Commit-Position: refs/heads/master@{#431556}

[gsennton, 2016-11-11 13:20:40]

gsennton@chromium.org changed reviewers:
+ torne@chromium.org

[gsennton, 2016-11-11 13:24:58]

On 2016/11/11 13:20:40, gsennton wrote:

unzip -v out-gn/Release/apks/SystemWebViewGoogle.apk | grep dex

before this CL
999208  Defl:N   430871  57% 2001-01-01 00:00 88717eb3  classes.dex

after this CL
999296  Defl:N   430908  57% 2001-01-01 00:00 f05957e7  classes.dex

diff:
uncompressed: 88,  compressed: 37

[Torne, 2016-11-11 13:30:32]

lgtm

[gsennton, 2016-11-11 13:31:16]

The CQ bit was checked by gsennton@chromium.org

[commit-bot: I haz the power, 2016-11-11 13:31:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 13:46:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-11 13:49:22]

Description was changed from

==========
WebView Proguard: Keep AwBrowserProcess.sExclusiveFileLock.

Static fields in Java are often assumed to stay alive throughout the
runtime of the entire program. However, the proguard
field/removal/writeonly optimization removes even static fields that are
only written to. This breaks some WebView code that relies on static
fields to hold onto a file-lock which prevents file-access from other
processes.

In this CL we explicitly tell proguard to keep
AwBrowserProcess.sExclusiveFileLock.

BUG=647291
==========

to

==========
WebView Proguard: Keep AwBrowserProcess.sExclusiveFileLock.

Static fields in Java are often assumed to stay alive throughout the
runtime of the entire program. However, the proguard
field/removal/writeonly optimization removes even static fields that are
only written to. This breaks some WebView code that relies on static
fields to hold onto a file-lock which prevents file-access from other
processes.

In this CL we explicitly tell proguard to keep
AwBrowserProcess.sExclusiveFileLock.

BUG=647291

Committed: https://crrev.com/d7730964c696db73bde4cc1ea6d07d3f09f85765
Cr-Commit-Position: refs/heads/master@{#431556}
==========

[commit-bot: I haz the power, 2016-11-11 13:49:23]

Patchset 2 (id:??) landed as
https://crrev.com/d7730964c696db73bde4cc1ea6d07d3f09f85765
Cr-Commit-Position: refs/heads/master@{#431556}