Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2489303003: [Cronet] Fix SdchTest.DictionaryAddedObserver (Closed)

Created:
4 years, 1 month ago by xunjieli
Modified:
4 years, 1 month ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Fix SdchTest.DictionaryAddedObserver The test run linked by the bug below seems to suggest that mBlock is null when we call mBlock.open(). This CL changes initialization of mBlock to be more compliant with the standard way of initialization member variables. BUG=664176 Committed: https://crrev.com/9049bdbc90b226e77758b7ae845584422f0663ac Cr-Commit-Position: refs/heads/master@{#431306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/SdchTest.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
xunjieli
Andrei, PTAL. Thanks!
4 years, 1 month ago (2016-11-10 15:35:21 UTC) #2
kapishnikov
lgtm
4 years, 1 month ago (2016-11-10 18:33:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489303003/1
4 years, 1 month ago (2016-11-10 18:34:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 18:59:14 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 19:09:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9049bdbc90b226e77758b7ae845584422f0663ac
Cr-Commit-Position: refs/heads/master@{#431306}

Powered by Google App Engine
This is Rietveld 408576698