Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: extensions/test/test_extensions_client.cc

Issue 2489233003: [extensions] Remove unnecessary checks in IsSensitiveURL (Closed)
Patch Set: Fix up code and write unit tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/test/test_extensions_client.cc
diff --git a/extensions/test/test_extensions_client.cc b/extensions/test/test_extensions_client.cc
index 5d928a5762aa1530904c6f5c37a133943214af56..600bc2d9892887766c68e2ec78d8b57c11b8fcfd 100644
--- a/extensions/test/test_extensions_client.cc
+++ b/extensions/test/test_extensions_client.cc
@@ -156,7 +156,7 @@ std::string TestExtensionsClient::GetWebstoreUpdateURL() const {
}
bool TestExtensionsClient::IsBlacklistUpdateURL(const GURL& url) const {
- return true;
+ return false;
Charlie Harrison 2016/11/10 22:10:20 unit tests pass with this but I'm not sure if brow
Devlin 2016/11/10 22:26:40 I think this should be fine. Not sure why the def
}
std::set<base::FilePath> TestExtensionsClient::GetBrowserImagePaths(

Powered by Google App Engine
This is Rietveld 408576698