Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2489203002: support uploading sub-rectangles of ImageData (Closed)

Created:
4 years, 1 month ago by Kai Ninomiya
Modified:
4 years, 1 month ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, haraken, Rik, f(malita), blink-reviews, piman+watch_chromium.org, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

support uploading sub-rectangles of ImageData BUG=639145 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/12e06d3d511e01173cf9af88e2f3b0bb1dddda22 Cr-Commit-Position: refs/heads/master@{#431182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -42 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 3 chunks +15 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 3 chunks +33 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 9 chunks +44 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Kai Ninomiya
kbr: PTAL
4 years, 1 month ago (2016-11-10 03:52:31 UTC) #7
Ken Russell (switch to Gerrit)
Excellent work. Looks perfect. LGTM Let me CQ this for you to get in sooner.
4 years, 1 month ago (2016-11-10 04:30:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489203002/1
4 years, 1 month ago (2016-11-10 04:31:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 04:36:18 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 04:43:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12e06d3d511e01173cf9af88e2f3b0bb1dddda22
Cr-Commit-Position: refs/heads/master@{#431182}

Powered by Google App Engine
This is Rietveld 408576698