base/PRESUBMIT.py - Issue 2489153003: Enforce clang-format in //base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/PRESUBMIT.py

Issue 2489153003: Enforce clang-format in //base (Closed)

Patch Set: presubmit only Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/PRESUBMIT.py

diff --git a/base/PRESUBMIT.py b/base/PRESUBMIT.py

index 7fc8107658c15a1c50fc633551b8618c958a5032..77686044068d719affa6613edaa5f28ef11cb465 100644

--- a/base/PRESUBMIT.py

+++ b/base/PRESUBMIT.py

@@ -35,6 +35,8 @@ def _CommonChecks(input_api, output_api):

"""Checks common to both upload and commit."""

results = []

results.extend(_CheckNoInterfacesInBase(input_api, output_api))

+ results.extend(

+ input_api.canned_checks.CheckPatchFormatted(input_api, output_api))

danakj 2016/11/10 23:06:51 You might want this only on upload though? I'm not

return results

def CheckChangeOnUpload(input_api, output_api):

« no previous file with comments | « no previous file | no next file » | no next file with comments »