Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2489133002: Set initializer expressions for default values of parameters of local functions. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set initializer expressions for default values of parameters of local functions. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/355a5f966485cd24acf0c9b144d1b1153eec65ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -5 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +20 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-09 22:51:11 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-09 22:55:48 UTC) #2
Paul Berry
lgtm
4 years, 1 month ago (2016-11-09 22:59:10 UTC) #3
scheglov
4 years, 1 month ago (2016-11-09 23:01:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
355a5f966485cd24acf0c9b144d1b1153eec65ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698