Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Issue 2489123002: Drop LegacyInterfaceTypeChecking for SpeechSynthesisUtterance (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop LegacyInterfaceTypeChecking for SpeechSynthesisUtterance The spec and Gecko don't have anything equivalent: https://dvcs.w3.org/hg/speech-api/raw-file/tip/webspeechapi.html#tts-section https://github.com/mozilla/gecko-dev/blob/master/dom/webidl/SpeechSynthesisUtterance.webidl BUG=561338 Committed: https://crrev.com/0e33dadcaf3d1c69c3183d13eb68ff0b173f9b94 Cr-Commit-Position: refs/heads/master@{#431225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-utterance-voice.html View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.idl View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
foolip
PTAL
4 years, 1 month ago (2016-11-09 22:25:08 UTC) #4
dmazzoni
lgtm
4 years, 1 month ago (2016-11-10 01:04:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489123002/1
4 years, 1 month ago (2016-11-10 09:42:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 09:47:07 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 09:51:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e33dadcaf3d1c69c3183d13eb68ff0b173f9b94
Cr-Commit-Position: refs/heads/master@{#431225}

Powered by Google App Engine
This is Rietveld 408576698