Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2489103002: Don't disable threaded input handling if rubberbanding is disabled. (Closed)

Created:
4 years, 1 month ago by dtapuska
Modified:
4 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't disable threaded input handling if rubberbanding is disabled. It appears this path of code was left in for when threaded input handling was written for OSX. It ended getting adjusted to not be based on a command line flag but eventually on a user setting. Since threaded input handling works correctly even though rubberbanding is disabled ensure that we always use threaded input handling. This was a problem because when threaded input handling isn't used every mouse move ends up generating a post event to the main thread and the events don't get coalesced. This isn't really a concern because threaded input handling is always expected to be enabled. BUG=662328 Committed: https://crrev.com/2422a4e2a7e6b13b8ab3f817912032ba16c7bd73 Cr-Commit-Position: refs/heads/master@{#431042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dtapuska
4 years, 1 month ago (2016-11-09 20:56:32 UTC) #2
piman
lgtm
4 years, 1 month ago (2016-11-09 21:05:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489103002/1
4 years, 1 month ago (2016-11-09 21:07:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 21:46:39 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 21:59:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2422a4e2a7e6b13b8ab3f817912032ba16c7bd73
Cr-Commit-Position: refs/heads/master@{#431042}

Powered by Google App Engine
This is Rietveld 408576698