Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2489083002: Revert of Disable scrollbar snapback on desktop Linux (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, Peter Kasting
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable scrollbar snapback on desktop Linux (patchset #2 id:20001 of https://codereview.chromium.org/2483113002/ ) Reason for revert: Looks like this broke a layout test: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise/builds/2219 https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Precise/2219/layout-test-results/results.html So I'm reverting it. Sorry! It is unfortunate that we don't run the layout tests on all content changes yet :(. Original issue's description: > Disable scrollbar snapback on desktop Linux > > This CL disables scrollbar snapback to be more consistent with typical > desktop Linux UI. Additionally, rename > webscrollbarbehavior_impl_gtkoraura* to > webscrollbarbehavior_impl_aura* since there's no longer a GTK backend > for Linux Chromium. > > BUG=567968 > > Committed: https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f > Cr-Commit-Position: refs/heads/master@{#430994} TBR=clamy@chromium.org,pkasting@chromium.org,thomasanderson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=567968 Committed: https://crrev.com/a79e2cf11821dbe91cb4fd52026a5df29a22ef25 Cr-Commit-Position: refs/heads/master@{#431015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -89 lines) Patch
M content/renderer/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/renderer/webscrollbarbehavior_impl_aura.h View 1 chunk +0 lines, -24 lines 0 comments Download
D content/renderer/webscrollbarbehavior_impl_aura.cc View 1 chunk +0 lines, -60 lines 0 comments Download
A content/renderer/webscrollbarbehavior_impl_gtkoraura.h View 1 chunk +24 lines, -0 lines 0 comments Download
A content/renderer/webscrollbarbehavior_impl_gtkoraura.cc View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
Created Revert of Disable scrollbar snapback on desktop Linux
4 years, 1 month ago (2016-11-09 19:53:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489083002/1
4 years, 1 month ago (2016-11-09 19:53:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 19:55:02 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 20:14:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a79e2cf11821dbe91cb4fd52026a5df29a22ef25
Cr-Commit-Position: refs/heads/master@{#431015}

Powered by Google App Engine
This is Rietveld 408576698