Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2489043003: MD Settings: Fix search engines dots icon centering. (Closed)

Created:
4 years, 1 month ago by dpapad
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix search engines dots icon centering. BUG=621413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c5d74227c9d1a7b78ea14389baaf6a912fd6e660 Cr-Commit-Position: refs/heads/master@{#431144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dpapad
Unfortunately removing right XOR left padding only from a paper-icon-button does not automatically update the ...
4 years, 1 month ago (2016-11-10 00:50:52 UTC) #3
Dan Beam
lgtm
4 years, 1 month ago (2016-11-10 00:57:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489043003/1
4 years, 1 month ago (2016-11-10 01:05:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 02:14:28 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 02:16:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5d74227c9d1a7b78ea14389baaf6a912fd6e660
Cr-Commit-Position: refs/heads/master@{#431144}

Powered by Google App Engine
This is Rietveld 408576698