Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2489033005: Web MIDI: deprecate MIDIMessageEvent.receivedTime (Closed)

Created:
4 years, 1 month ago by Takashi Toyoshima
Modified:
4 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, haraken, toyoshim+midi_chromium.org, yhirano
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: deprecate MIDIMessageEvent.receivedTime As we planned, drop MIDIMessageEvent.receivedTime support from Web MIDI. This is because Event can provide timeStamp in HighResTimeStamp today. https://groups.google.com/a/chromium.org/d/topic/blink-dev/sT4M99V29SE/discussion BUG=599335 Committed: https://crrev.com/78d9022f114359c780331d9a6e8a34ce8cdbf6fa Cr-Commit-Position: refs/heads/master@{#431843}

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : fix layout test expectations #

Patch Set 4 : [rebase] #

Total comments: 2

Patch Set 5 : drop ConstructorCallWith=ExecutionContext #

Patch Set 6 : expectation for virtual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -100 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/constructors/midi-message-event-constructor.html View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/constructors/midi-message-event-constructor-expected.txt View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webmidi/loopback-receive.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webmidi/loopback-receive-expected.txt View 2 chunks +0 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp View 1 chunk +1 line, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.h View 1 2 3 4 2 chunks +7 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.cpp View 1 2 3 4 1 chunk +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl View 1 2 3 4 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIMessageEventInit.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 29 (21 generated)
Takashi Toyoshima
ptal
4 years, 1 month ago (2016-11-14 03:55:02 UTC) #9
tkent
lgtm https://codereview.chromium.org/2489033005/diff/60001/third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl File third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl (left): https://codereview.chromium.org/2489033005/diff/60001/third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl#oldcode33 third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl:33: // TODO(toyoshim): Remove ConstructorCallWith=ExecutionContext and receivedTime. The TODO ...
4 years, 1 month ago (2016-11-14 04:07:30 UTC) #10
Takashi Toyoshima
cc: yhirano just in case for modules/webmidi https://codereview.chromium.org/2489033005/diff/60001/third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl File third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl (left): https://codereview.chromium.org/2489033005/diff/60001/third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl#oldcode33 third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl:33: // TODO(toyoshim): ...
4 years, 1 month ago (2016-11-14 04:55:12 UTC) #13
Takashi Toyoshima
I uploaded Patch Set 6 since Patch Set 5 still had some expectations that should ...
4 years, 1 month ago (2016-11-14 06:32:03 UTC) #18
tkent
still lgtm
4 years, 1 month ago (2016-11-14 06:35:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489033005/100001
4 years, 1 month ago (2016-11-14 08:38:53 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-11-14 08:42:53 UTC) #27
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 08:44:59 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/78d9022f114359c780331d9a6e8a34ce8cdbf6fa
Cr-Commit-Position: refs/heads/master@{#431843}

Powered by Google App Engine
This is Rietveld 408576698