DevTools: hosted mode fallback if generated files aren't uploaded yet

DevTools: hosted mode fallback if generated files aren't uploaded yet

Hosted mode fetches a couple of generated files from the cloud. Because there's
a delay between when a commit lands in trunk and when it's uploaded to appspot, oftentimes
users experience an error when trying to run hosted mode with Chromium close to tip of
tree. This provides a fallback so that the hosted mode proxy server tries to fetch
it an earlier revision of the same file.

BUG=629914
Committed: https://crrev.com/c1da08f9c7e7e856d7f1fb9bed9b838e058a7ba7
Cr-Commit-Position: refs/heads/master@{#432044}

[chenwilliam, 2016-11-10 02:10:44]

Description was changed from

==========
DevTools: hosted mode fallback if generated files aren't uploaded yet

Hosted mode fetches a couple of generated files from the cloud. Because there's
a delay between a commit lands in trunk and when it's uploaded to appspot,
oftentimes
users experience an error when trying to run hosted mode with Chromium close to
tip of
tree. This provides a fallback so that the hosted mode proxy server tries to
fetch
it an earlier revision of the same file.

BUG=2493573003
==========

to

==========
DevTools: hosted mode fallback if generated files aren't uploaded yet

Hosted mode fetches a couple of generated files from the cloud. Because there's
a delay between when a commit lands in trunk and when it's uploaded to appspot,
oftentimes
users experience an error when trying to run hosted mode with Chromium close to
tip of
tree. This provides a fallback so that the hosted mode proxy server tries to
fetch
it an earlier revision of the same file.

BUG=2493573003
==========

[chenwilliam, 2016-11-10 02:28:55]

Patchset #2 (id:20001) has been deleted

[chenwilliam, 2016-11-10 18:39:07]

chenwilliam@chromium.org changed reviewers:
+ lushnikov@chromium.org

[chenwilliam, 2016-11-10 18:39:08]

PTAL. This relies on git being available on the PATH, but I think it's a fairly
safe assumption and I've tested the git commands work across OS (Linux, Windows,
Mac).

[lushnikov, 2016-11-14 22:24:34]

lgtm

https://codereview.chromium.org/2489033003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js (right):

https://codereview.chromium.org/2489033003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js:131:
earlierCommitHash = commitMessage.match(/Cr-Mirrored-Commit: (.*)/)[1];
can we use this codepath for both full and github checkouts?

[chenwilliam, 2016-11-14 23:47:30]

https://codereview.chromium.org/2489033003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js (right):

https://codereview.chromium.org/2489033003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js:131:
earlierCommitHash = commitMessage.match(/Cr-Mirrored-Commit: (.*)/)[1];
On 2016/11/14 22:24:34, lushnikov wrote:
> can we use this codepath for both full and github checkouts?

unfortunately we can't, because "Cr-Mirrored-Commit" is only added for our
subtree mirror.

https://codereview.chromium.org/2489033003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js (right):

https://codereview.chromium.org/2489033003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js:126: var
gitLogCommand = `git log --max-count=1 --grep="Commit-Position" --before="12
hours ago"`;
fixed the git grep so it works on full & front-end checkout since the main repo
has "Cr-Commit-Position:" and the mirror repo has "Cr-Original-Commit-Position:"

[chenwilliam, 2016-11-14 23:47:42]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-11-14 23:47:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2489033003/#ps60001
(title: "fix the git grep so it works on full & front-end checkout")

[chenwilliam, 2016-11-14 23:48:24]

Description was changed from

==========
DevTools: hosted mode fallback if generated files aren't uploaded yet

Hosted mode fetches a couple of generated files from the cloud. Because there's
a delay between when a commit lands in trunk and when it's uploaded to appspot,
oftentimes
users experience an error when trying to run hosted mode with Chromium close to
tip of
tree. This provides a fallback so that the hosted mode proxy server tries to
fetch
it an earlier revision of the same file.

BUG=2493573003
==========

to

==========
DevTools: hosted mode fallback if generated files aren't uploaded yet

Hosted mode fetches a couple of generated files from the cloud. Because there's
a delay between when a commit lands in trunk and when it's uploaded to appspot,
oftentimes
users experience an error when trying to run hosted mode with Chromium close to
tip of
tree. This provides a fallback so that the hosted mode proxy server tries to
fetch
it an earlier revision of the same file.

BUG=629914
==========

[commit-bot: I haz the power, 2016-11-14 23:48:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 01:08:39]

Description was changed from

==========
DevTools: hosted mode fallback if generated files aren't uploaded yet

Hosted mode fetches a couple of generated files from the cloud. Because there's
a delay between when a commit lands in trunk and when it's uploaded to appspot,
oftentimes
users experience an error when trying to run hosted mode with Chromium close to
tip of
tree. This provides a fallback so that the hosted mode proxy server tries to
fetch
it an earlier revision of the same file.

BUG=629914
==========

to

==========
DevTools: hosted mode fallback if generated files aren't uploaded yet

Hosted mode fetches a couple of generated files from the cloud. Because there's
a delay between when a commit lands in trunk and when it's uploaded to appspot,
oftentimes
users experience an error when trying to run hosted mode with Chromium close to
tip of
tree. This provides a fallback so that the hosted mode proxy server tries to
fetch
it an earlier revision of the same file.

BUG=629914
==========

[commit-bot: I haz the power, 2016-11-15 01:08:41]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-15 01:15:13]

Description was changed from

==========
DevTools: hosted mode fallback if generated files aren't uploaded yet

Hosted mode fetches a couple of generated files from the cloud. Because there's
a delay between when a commit lands in trunk and when it's uploaded to appspot,
oftentimes
users experience an error when trying to run hosted mode with Chromium close to
tip of
tree. This provides a fallback so that the hosted mode proxy server tries to
fetch
it an earlier revision of the same file.

BUG=629914
==========

to

==========
DevTools: hosted mode fallback if generated files aren't uploaded yet

Hosted mode fetches a couple of generated files from the cloud. Because there's
a delay between when a commit lands in trunk and when it's uploaded to appspot,
oftentimes
users experience an error when trying to run hosted mode with Chromium close to
tip of
tree. This provides a fallback so that the hosted mode proxy server tries to
fetch
it an earlier revision of the same file.

BUG=629914

Committed: https://crrev.com/c1da08f9c7e7e856d7f1fb9bed9b838e058a7ba7
Cr-Commit-Position: refs/heads/master@{#432044}
==========

[commit-bot: I haz the power, 2016-11-15 01:15:13]

Patchset 3 (id:??) landed as
https://crrev.com/c1da08f9c7e7e856d7f1fb9bed9b838e058a7ba7
Cr-Commit-Position: refs/heads/master@{#432044}