Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2489023002: Updata ninja to v1.7.2. (Closed)

Created:
4 years, 1 month ago by Nico
Modified:
4 years, 1 month ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updata ninja to v1.7.2. New binaries for Mac, Linux32, Linux64, Windows. Also update shell script. See the bug for how these were built. The main "new" thing is a regression fix where 1.7.1 broke %e %r in NINJA_STATUS. BUG=663749 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/28a1ff42d9477f548a37afc89813012b673b406c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ninja View 1 chunk +1 line, -1 line 0 comments Download
M ninja.exe View Binary file 0 comments Download
M ninja-linux32 View Binary file 0 comments Download
M ninja-linux64 View Binary file 0 comments Download
M ninja-mac View Binary file 0 comments Download

Messages

Total messages: 18 (9 generated)
Nico
4 years, 1 month ago (2016-11-09 17:17:09 UTC) #4
Dirk Pranke
lgtm. Though, I don't think we technically need the linux32 binary any more ...
4 years, 1 month ago (2016-11-09 17:24:22 UTC) #8
scottmg
lgtm
4 years, 1 month ago (2016-11-09 17:24:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489023002/1
4 years, 1 month ago (2016-11-09 17:26:15 UTC) #11
Nico
> Though, I don't think we technically need the linux32 binary any more ... thestig, ...
4 years, 1 month ago (2016-11-09 17:26:36 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/28a1ff42d9477f548a37afc89813012b673b406c
4 years, 1 month ago (2016-11-09 17:29:14 UTC) #15
Lei Zhang
On 2016/11/09 17:26:36, Nico wrote: > > Though, I don't think we technically need the ...
4 years, 1 month ago (2016-11-09 19:09:02 UTC) #16
Dirk Pranke
On 2016/11/09 19:09:02, Lei Zhang (slow) wrote: > On 2016/11/09 17:26:36, Nico wrote: > > ...
4 years, 1 month ago (2016-11-09 19:13:10 UTC) #17
Dirk Pranke
4 years, 1 month ago (2016-11-09 19:22:42 UTC) #18
Message was sent while issue was closed.
Looks like NaCl still has them, so we need to keep them for now. I'll follow up
w/ Bradley to see if we can shut them down.

Powered by Google App Engine
This is Rietveld 408576698