Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2488963003: Revert of Convert Site Isolation Win bot to --isolate-extensions [2nd attempt]. (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
brettw, jbudorick, alexmos, sky
CC:
chromium-reviews, jam, darin-cc_chromium.org, nasko, site-isolation-reviews_chromium.org, slan, servolk, Paweł Hajdan Jr.
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert Site Isolation Win bot to --isolate-extensions [2nd attempt]. (patchset #5 id:80001 of https://codereview.chromium.org/2469353002/ ) Reason for revert: amineer@ points out that https://crbug.com/663785 also affects Canary and Dev builds - the safest / fastest thing to do seems to be to just revert. Original issue's description: > Convert Site Isolation Win bot to --isolate-extensions [2nd attempt]. > > This is an attempt to reland https://crrev.com/2459813003 after: > > 1) proper merging (i.e. moving the diff hunks further down so they > apply to Site Isolation Win config, not to Site Isolation Linux > as they've accidentally been merged by CQ in the earlier CL) > > 2) adding data dependencies for the filter files > (with extra refactoring / consolidation to hopefully make things > easier / less surprising in the future). > > BUG=545200 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/e8b43a499acd3df1ff12f08f2652d4acca2695fd > Cr-Commit-Position: refs/heads/master@{#430603} TBR=alexmos@chromium.org,brettw@chromium.org,sky@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=545200 Committed: https://crrev.com/93df1d56c9b3979d5af155f7bb740d32f75aad38 Cr-Commit-Position: refs/heads/master@{#431038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -59 lines) Patch
M chrome/test/BUILD.gn View 3 chunks +9 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M testing/buildbot/chromium.fyi.json View 13 chunks +15 lines, -15 lines 0 comments Download
D testing/buildbot/filters/BUILD.gn View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Łukasz Anforowicz
Created Revert of Convert Site Isolation Win bot to --isolate-extensions [2nd attempt].
4 years, 1 month ago (2016-11-09 20:28:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488963003/1
4 years, 1 month ago (2016-11-09 20:28:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 21:38:38 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 21:52:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93df1d56c9b3979d5af155f7bb740d32f75aad38
Cr-Commit-Position: refs/heads/master@{#431038}

Powered by Google App Engine
This is Rietveld 408576698