Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2488873004: Filter CatalogViewer results by capability. (Closed)

Created:
4 years, 1 month ago by Hadi
Modified:
4 years, 1 month ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Filter CatalogViewer results by capability. Being able to filter catalog results by capability can be useful for some debugging situations. This CL adds a textfield to catalog_viewer to allow filtering by capability. The user enters the capability in the textfield and hits return. If it is empty, all entries are loaded. Otherwise they are filtered by capability. BUG=663808 Committed: https://crrev.com/dfeb74985ea781bc05ccab028a5f30e46aea9def Cr-Commit-Position: refs/heads/master@{#431024}

Patch Set 1 #

Patch Set 2 : Better UI. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -21 lines) Patch
M mash/catalog_viewer/catalog_viewer.cc View 1 6 chunks +71 lines, -21 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Hadi
PTAL.
4 years, 1 month ago (2016-11-09 18:40:45 UTC) #3
Ben Goodger (Google)
lgtm
4 years, 1 month ago (2016-11-09 20:32:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488873004/20001
4 years, 1 month ago (2016-11-09 20:33:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 20:37:33 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 21:00:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfeb74985ea781bc05ccab028a5f30e46aea9def
Cr-Commit-Position: refs/heads/master@{#431024}

Powered by Google App Engine
This is Rietveld 408576698